From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: linuxppc-dev@lists.ozlabs.org, Michael Ellerman <mpe@ellerman.id.au>
Cc: jniethe5@gmail.com, mahesh@linux.ibm.com, joel@jms.id.au
Subject: Re: [PATCH 1/2] powerpc/powernv: Fix fortify source warnings in opal-prd.c
Date: Thu, 31 Aug 2023 14:02:30 +1000 [thread overview]
Message-ID: <169345455028.11824.13478126684024151530.b4-ty@ellerman.id.au> (raw)
In-Reply-To: <20230821142820.497107-1-mpe@ellerman.id.au>
On Tue, 22 Aug 2023 00:28:19 +1000, Michael Ellerman wrote:
> As reported by Mahesh & Aneesh, opal_prd_msg_notifier() triggers a
> FORTIFY_SOURCE warning:
>
> memcpy: detected field-spanning write (size 32) of single field "&item->msg" at arch/powerpc/platforms/powernv/opal-prd.c:355 (size 4)
> WARNING: CPU: 9 PID: 660 at arch/powerpc/platforms/powernv/opal-prd.c:355 opal_prd_msg_notifier+0x174/0x188 [opal_prd]
> NIP opal_prd_msg_notifier+0x174/0x188 [opal_prd]
> LR opal_prd_msg_notifier+0x170/0x188 [opal_prd]
> Call Trace:
> opal_prd_msg_notifier+0x170/0x188 [opal_prd] (unreliable)
> notifier_call_chain+0xc0/0x1b0
> atomic_notifier_call_chain+0x2c/0x40
> opal_message_notify+0xf4/0x2c0
>
> [...]
Applied to powerpc/next.
[1/2] powerpc/powernv: Fix fortify source warnings in opal-prd.c
https://git.kernel.org/powerpc/c/feea65a338e52297b68ceb688eaf0ffc50310a83
[2/2] powerpc/powernv: Use struct opal_prd_msg in more places
https://git.kernel.org/powerpc/c/22b165617b779418166319a19fd926a9c6feb9a3
cheers
prev parent reply other threads:[~2023-08-31 4:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 14:28 [PATCH 1/2] powerpc/powernv: Fix fortify source warnings in opal-prd.c Michael Ellerman
2023-08-21 14:28 ` [PATCH 2/2] powerpc/powernv: Use struct opal_prd_msg in more places Michael Ellerman
2023-08-23 2:58 ` [PATCH 1/2] powerpc/powernv: Fix fortify source warnings in opal-prd.c Mahesh J Salgaonkar
2023-08-31 4:02 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169345455028.11824.13478126684024151530.b4-ty@ellerman.id.au \
--to=patch-notifications@ellerman.id.au \
--cc=jniethe5@gmail.com \
--cc=joel@jms.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mahesh@linux.ibm.com \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.