From: Kalle Valo <kvalo@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org,
Johannes Berg <johannes.berg@intel.com>,
Miri Korenblit <miriam.rachel.korenblit@intel.com>,
Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Subject: Re: [PATCH] wifi: iwlwifi: pcie: don't synchronize IRQs from IRQ
Date: Mon, 18 Dec 2023 16:42:08 +0000 (UTC) [thread overview]
Message-ID: <170291772631.360676.241613506722082972.kvalo@kernel.org> (raw)
In-Reply-To: <20231215111335.59aab00baed7.Iadfe154d6248e7f9dfd69522e5429dbbd72925d7@changeid>
Johannes Berg <johannes@sipsolutions.net> wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> On older devices (before unified image!) we can end up calling
> stop_device from an rfkill interrupt. However, in stop_device
> we attempt to synchronize IRQs, which then of course deadlocks.
>
> Avoid this by checking the context, if running from the IRQ
> thread then don't synchronize. This wouldn't be correct on a
> new device since RSS is supported, but older devices only have
> a single interrupt/queue.
>
> Fixes: 37fb29bd1f90 ("wifi: iwlwifi: pcie: synchronize IRQs before NAPI")
> Reviewed-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
> Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Patch applied to wireless.git, thanks.
400f6ebbc175 wifi: iwlwifi: pcie: don't synchronize IRQs from IRQ
--
https://patchwork.kernel.org/project/linux-wireless/patch/20231215111335.59aab00baed7.Iadfe154d6248e7f9dfd69522e5429dbbd72925d7@changeid/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2023-12-18 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 10:13 [PATCH] wifi: iwlwifi: pcie: don't synchronize IRQs from IRQ Johannes Berg
2023-12-18 16:42 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170291772631.360676.241613506722082972.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.