From: Kalle Valo <kvalo@kernel.org>
To: "Jérôme Pouiller" <jerome.pouiller@silabs.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-devel@silabs.com,
"Jérôme Pouiller" <jerome.pouiller@silabs.com>,
"Ulrich Mohr" <u.mohr@semex-engcon.com>
Subject: Re: [PATCH] wifi: wfx: fix memory leak when starting AP
Date: Tue, 6 Feb 2024 18:06:58 +0000 (UTC) [thread overview]
Message-ID: <170724281653.1979906.14756847148616354771.kvalo@kernel.org> (raw)
In-Reply-To: <20240202164213.1606145-1-jerome.pouiller@silabs.com>
Jérôme Pouiller <jerome.pouiller@silabs.com> wrote:
> Kmemleak reported this error:
>
> unreferenced object 0xd73d1180 (size 184):
> comm "wpa_supplicant", pid 1559, jiffies 13006305 (age 964.245s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 00 00 00 00 00 00 00 00 1e 00 01 00 00 00 00 00 ................
> backtrace:
> [<5ca11420>] kmem_cache_alloc+0x20c/0x5ac
> [<127bdd74>] __alloc_skb+0x144/0x170
> [<fb8a5e38>] __netdev_alloc_skb+0x50/0x180
> [<0f9fa1d5>] __ieee80211_beacon_get+0x290/0x4d4 [mac80211]
> [<7accd02d>] ieee80211_beacon_get_tim+0x54/0x18c [mac80211]
> [<41e25cc3>] wfx_start_ap+0xc8/0x234 [wfx]
> [<93a70356>] ieee80211_start_ap+0x404/0x6b4 [mac80211]
> [<a4a661cd>] nl80211_start_ap+0x76c/0x9e0 [cfg80211]
> [<47bd8b68>] genl_rcv_msg+0x198/0x378
> [<453ef796>] netlink_rcv_skb+0xd0/0x130
> [<6b7c977a>] genl_rcv+0x34/0x44
> [<66b2d04d>] netlink_unicast+0x1b4/0x258
> [<f965b9b6>] netlink_sendmsg+0x1e8/0x428
> [<aadb8231>] ____sys_sendmsg+0x1e0/0x274
> [<d2b5212d>] ___sys_sendmsg+0x80/0xb4
> [<69954f45>] __sys_sendmsg+0x64/0xa8
> unreferenced object 0xce087000 (size 1024):
> comm "wpa_supplicant", pid 1559, jiffies 13006305 (age 964.246s)
> hex dump (first 32 bytes):
> 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> 10 00 07 40 00 00 00 00 00 00 00 00 00 00 00 00 ...@............
> backtrace:
> [<9a993714>] __kmalloc_track_caller+0x230/0x600
> [<f83ea192>] kmalloc_reserve.constprop.0+0x30/0x74
> [<a2c61343>] __alloc_skb+0xa0/0x170
> [<fb8a5e38>] __netdev_alloc_skb+0x50/0x180
> [<0f9fa1d5>] __ieee80211_beacon_get+0x290/0x4d4 [mac80211]
> [<7accd02d>] ieee80211_beacon_get_tim+0x54/0x18c [mac80211]
> [<41e25cc3>] wfx_start_ap+0xc8/0x234 [wfx]
> [<93a70356>] ieee80211_start_ap+0x404/0x6b4 [mac80211]
> [<a4a661cd>] nl80211_start_ap+0x76c/0x9e0 [cfg80211]
> [<47bd8b68>] genl_rcv_msg+0x198/0x378
> [<453ef796>] netlink_rcv_skb+0xd0/0x130
> [<6b7c977a>] genl_rcv+0x34/0x44
> [<66b2d04d>] netlink_unicast+0x1b4/0x258
> [<f965b9b6>] netlink_sendmsg+0x1e8/0x428
> [<aadb8231>] ____sys_sendmsg+0x1e0/0x274
> [<d2b5212d>] ___sys_sendmsg+0x80/0xb4
>
> However, since the kernel is build optimized, it seems the stack is not
> accurate. It appears the issue is related to wfx_set_mfp_ap(). The issue
> is obvious in this function: memory allocated by ieee80211_beacon_get()
> is never released. Fixing this leak makes kmemleak happy.
>
> Reported-by: Ulrich Mohr <u.mohr@semex-engcon.com>
> Co-developed-by: Ulrich Mohr <u.mohr@semex-engcon.com>
> Signed-off-by: Ulrich Mohr <u.mohr@semex-engcon.com>
> Fixes: 268bceec1684 ("staging: wfx: fix BA when device is AP and MFP is enabled")
> Signed-off-by: Jérôme Pouiller <jerome.pouiller@silabs.com>
Patch applied to wireless-next.git, thanks.
b8cfb7c819dd wifi: wfx: fix memory leak when starting AP
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240202164213.1606145-1-jerome.pouiller@silabs.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2024-02-06 18:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 16:42 [PATCH] wifi: wfx: fix memory leak when starting AP Jérôme Pouiller
2024-02-06 18:06 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170724281653.1979906.14756847148616354771.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=jerome.pouiller@silabs.com \
--cc=linux-devel@silabs.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=u.mohr@semex-engcon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.