From: Mark Brown <broonie@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Srinivasa Rao Mandadapu <quic_srivasam@quicinc.com>,
Venkata Prasad Potturu <quic_potturu@quicinc.com>,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
Colin Ian King <colin.i.king@gmail.com>
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: qcom: Fix uninitialized pointer dmactl
Date: Wed, 21 Feb 2024 16:02:54 +0000 [thread overview]
Message-ID: <170853137427.40410.4918124750403655559.b4-ty@kernel.org> (raw)
In-Reply-To: <20240221134804.3475989-1-colin.i.king@gmail.com>
On Wed, 21 Feb 2024 13:48:04 +0000, Colin Ian King wrote:
> In the case where __lpass_get_dmactl_handle is called and the driver
> id dai_id is invalid the pointer dmactl is not being assigned a value,
> and dmactl contains a garbage value since it has not been initialized
> and so the null check may not work. Fix this to initialize dmactl to
> NULL. One could argue that modern compilers will set this to zero, but
> it is useful to keep this initialized as per the same way in functions
> __lpass_platform_codec_intf_init and lpass_cdc_dma_daiops_hw_params.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: qcom: Fix uninitialized pointer dmactl
commit: 1382d8b55129875b2e07c4d2a7ebc790183769ee
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
prev parent reply other threads:[~2024-02-21 16:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 13:48 [PATCH] ASoC: qcom: Fix uninitialized pointer dmactl Colin Ian King
2024-02-21 16:02 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170853137427.40410.4918124750403655559.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=colin.i.king@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=quic_potturu@quicinc.com \
--cc=quic_srivasam@quicinc.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.