From: Kalle Valo <kvalo@kernel.org>
To: "Alexis Lothoré" <alexis.lothore@bootlin.com>
Cc: linux-wireless@vger.kernel.org,
"Ajay Singh" <ajay.kathat@microchip.com>,
"Claudiu Beznea" <claudiu.beznea@tuxon.dev>,
"David Mosberger-Tang" <davidm@egauge.net>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
linux-kernel@vger.kernel.org,
"Conor Dooley" <conor.dooley@microchip.com>,
"Alexis Lothoré" <alexis.lothore@bootlin.com>
Subject: Re: [PATCH v2] wifi: wilc1000: revert reset line logic flip
Date: Wed, 21 Feb 2024 18:56:53 +0000 (UTC) [thread overview]
Message-ID: <170854181192.1918455.14748300319931361175.kvalo@kernel.org> (raw)
In-Reply-To: <20240217-wilc_1000_reset_line-v2-1-b216f433d7d5@bootlin.com>
Alexis Lothoré <alexis.lothore@bootlin.com> wrote:
> This reverts commit fcf690b0b47494df51d214db5c5a714a400b0257.
>
> When using a wilc1000 chip over a spi bus, users can optionally define a
> reset gpio and a chip enable gpio. The reset line of wilc1000 is active
> low, so to hold the chip in reset, a low (physical) value must be applied.
>
> The corresponding device tree binding documentation was introduced by
> commit f31ee3c0a555 ("wilc1000: Document enable-gpios and reset-gpios
> properties") and correctly indicates that the reset line is an active-low
> signal. The corresponding driver part, brought by commit ec031ac4792c
> ("wilc1000: Add reset/enable GPIO support to SPI driver") was applying the
> correct logic. But commit fcf690b0b474 ("wifi: wilc1000: use correct
> sequence of RESET for chip Power-UP/Down") eventually flipped this logic
> and started misusing the gpiod APIs, applying an inverted logic when
> powering up/down the chip (for example, setting the reset line to a logic
> "1" during power up, which in fact asserts the reset line when device tree
> describes the reset line as GPIO_ACTIVE_LOW). As a consequence, any
> platform currently using the driver in SPI mode must use a faulty reset
> line description in device tree, or else chip will be maintained in reset
> and will not even allow to bring up the chip.
>
> Fix reset line usage by inverting back the gpiod APIs usage, setting the
> reset line to the logic value "0" when powering the chip, and the logic
> value "1" when powering off the chip.
>
> Fixes: fcf690b0b474 ("wifi: wilc1000: use correct sequence of RESET for chip Power-UP/Down")
> Signed-off-by: Alexis Lothoré <alexis.lothore@bootlin.com>
> Acked-by: Conor Dooley <conor.dooley@microchip.com>
> Acked-by: Ajay Singh <ajay.kathat@microchip.com>
Patch applied to wireless-next.git, thanks.
f3ec64394763 wifi: wilc1000: revert reset line logic flip
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240217-wilc_1000_reset_line-v2-1-b216f433d7d5@bootlin.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2024-02-21 18:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-17 13:22 [PATCH v2] wifi: wilc1000: revert reset line logic flip Alexis Lothoré
2024-02-21 18:56 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170854181192.1918455.14748300319931361175.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=ajay.kathat@microchip.com \
--cc=alexis.lothore@bootlin.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor.dooley@microchip.com \
--cc=davidm@egauge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.