From: Mark Brown <broonie@kernel.org>
To: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
Stephen Lee <slee08177@gmail.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-sound@vger.kernel.org, roman.gushchin@linux.dev,
dennis@kernel.org
Subject: Re: [PATCH] ASoC: ops: Fix wraparound for mask in snd_soc_get_volsw
Date: Fri, 29 Mar 2024 01:29:01 +0000 [thread overview]
Message-ID: <171167574149.187137.12642574967939100311.b4-ty@kernel.org> (raw)
In-Reply-To: <20240326010131.6211-1-slee08177@gmail.com>
On Mon, 25 Mar 2024 18:01:31 -0700, Stephen Lee wrote:
> In snd_soc_info_volsw(), mask is generated by figuring out the index of
> the most significant bit set in max and converting the index to a
> bitmask through bit shift 1. Unintended wraparound occurs when max is an
> integer value with msb bit set. Since the bit shift value 1 is treated
> as an integer type, the left shift operation will wraparound and set
> mask to 0 instead of all 1's. In order to fix this, we type cast 1 as
> `1ULL` to prevent the wraparound.
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: ops: Fix wraparound for mask in snd_soc_get_volsw
commit: fc563aa900659a850e2ada4af26b9d7a3de6c591
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
prev parent reply other threads:[~2024-03-29 1:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-26 1:01 [PATCH] ASoC: ops: Fix wraparound for mask in snd_soc_get_volsw Stephen Lee
2024-03-28 19:28 ` Mark Brown
2024-03-29 1:29 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171167574149.187137.12642574967939100311.b4-ty@kernel.org \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=dennis@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=roman.gushchin@linux.dev \
--cc=slee08177@gmail.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.