From: ndesaulniers@google.com
To: Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Nathan Chancellor <nathan@kernel.org>, Tom Rix <trix@redhat.com>
Cc: Joel Stanley <joel@jms.id.au>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
llvm@lists.linux.dev, Nick Desaulniers <ndesaulniers@google.com>
Subject: [PATCH] Revert "powerpc/xmon: Relax frame size for clang"
Date: Thu, 17 Aug 2023 11:11:56 -0700 [thread overview]
Message-ID: <20230817-ppc_xmon-v1-1-8cc2d51b9995@google.com> (raw)
This reverts commit 9c87156cce5a63735d1218f0096a65c50a7a32aa.
I have not been able to reproduce the reported -Wframe-larger-than=
warning (or disassembly) with clang-11 or clang-18.
I don't know precisely when this was fixed in llvm, but it may be time
to revert this.
Closes: https://github.com/ClangBuiltLinux/linux/issues/252
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
arch/powerpc/xmon/Makefile | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/powerpc/xmon/Makefile b/arch/powerpc/xmon/Makefile
index d334de392e6c..7705aa74a24d 100644
--- a/arch/powerpc/xmon/Makefile
+++ b/arch/powerpc/xmon/Makefile
@@ -10,12 +10,6 @@ KCSAN_SANITIZE := n
# Disable ftrace for the entire directory
ccflags-remove-$(CONFIG_FUNCTION_TRACER) += $(CC_FLAGS_FTRACE)
-ifdef CONFIG_CC_IS_CLANG
-# clang stores addresses on the stack causing the frame size to blow
-# out. See https://github.com/ClangBuiltLinux/linux/issues/252
-KBUILD_CFLAGS += -Wframe-larger-than=4096
-endif
-
ccflags-$(CONFIG_PPC64) := $(NO_MINIMAL_TOC)
obj-y += xmon.o nonstdio.o spr_access.o xmon_bpts.o
---
base-commit: 16931859a6500d360b90aeacab3b505a3560a3ed
change-id: 20230817-ppc_xmon-d288d803610e
Best regards,
--
Nick Desaulniers <ndesaulniers@google.com>
WARNING: multiple messages have this Message-ID (diff)
From: ndesaulniers@google.com
To: Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Nathan Chancellor <nathan@kernel.org>, Tom Rix <trix@redhat.com>
Cc: Nick Desaulniers <ndesaulniers@google.com>,
llvm@lists.linux.dev, linuxppc-dev@lists.ozlabs.org,
Joel Stanley <joel@jms.id.au>,
linux-kernel@vger.kernel.org
Subject: [PATCH] Revert "powerpc/xmon: Relax frame size for clang"
Date: Thu, 17 Aug 2023 11:11:56 -0700 [thread overview]
Message-ID: <20230817-ppc_xmon-v1-1-8cc2d51b9995@google.com> (raw)
This reverts commit 9c87156cce5a63735d1218f0096a65c50a7a32aa.
I have not been able to reproduce the reported -Wframe-larger-than=
warning (or disassembly) with clang-11 or clang-18.
I don't know precisely when this was fixed in llvm, but it may be time
to revert this.
Closes: https://github.com/ClangBuiltLinux/linux/issues/252
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
---
arch/powerpc/xmon/Makefile | 6 ------
1 file changed, 6 deletions(-)
diff --git a/arch/powerpc/xmon/Makefile b/arch/powerpc/xmon/Makefile
index d334de392e6c..7705aa74a24d 100644
--- a/arch/powerpc/xmon/Makefile
+++ b/arch/powerpc/xmon/Makefile
@@ -10,12 +10,6 @@ KCSAN_SANITIZE := n
# Disable ftrace for the entire directory
ccflags-remove-$(CONFIG_FUNCTION_TRACER) += $(CC_FLAGS_FTRACE)
-ifdef CONFIG_CC_IS_CLANG
-# clang stores addresses on the stack causing the frame size to blow
-# out. See https://github.com/ClangBuiltLinux/linux/issues/252
-KBUILD_CFLAGS += -Wframe-larger-than=4096
-endif
-
ccflags-$(CONFIG_PPC64) := $(NO_MINIMAL_TOC)
obj-y += xmon.o nonstdio.o spr_access.o xmon_bpts.o
---
base-commit: 16931859a6500d360b90aeacab3b505a3560a3ed
change-id: 20230817-ppc_xmon-d288d803610e
Best regards,
--
Nick Desaulniers <ndesaulniers@google.com>
next reply other threads:[~2023-08-17 18:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 18:11 ndesaulniers [this message]
2023-08-17 18:11 ` [PATCH] Revert "powerpc/xmon: Relax frame size for clang" ndesaulniers
2023-08-17 18:43 ` Nathan Chancellor
2023-08-17 18:43 ` Nathan Chancellor
2023-08-23 11:55 ` Michael Ellerman
2023-08-23 11:55 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230817-ppc_xmon-v1-1-8cc2d51b9995@google.com \
--to=ndesaulniers@google.com \
--cc=christophe.leroy@csgroup.eu \
--cc=joel@jms.id.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=mpe@ellerman.id.au \
--cc=nathan@kernel.org \
--cc=npiggin@gmail.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.