From: "Nysal Jan K.A." <nysal@linux.ibm.com>
To: Nicholas Piggin <npiggin@gmail.com>
Cc: Shrikanth Hegde <sshegde@linux.vnet.ibm.com>,
linuxppc-dev@lists.ozlabs.org,
Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Subject: Re: [PATCH 0/6] powerpc/qspinlock: Fix yield latency bug and other
Date: Fri, 20 Oct 2023 15:34:29 +0530 [thread overview]
Message-ID: <20231020100429.GB213288@li-80eaad4c-2afd-11b2-a85c-af8123d033e3.ibm.com> (raw)
In-Reply-To: <20231016124305.139923-1-npiggin@gmail.com>
On Mon, Oct 16, 2023 at 10:42:59PM +1000, Nicholas Piggin wrote:
> This fixes a long-standing latency bug in the powerpc qspinlock
> implementation that quite a few people have reported and helped
> out with debugging.
>
> The first patch is a minimal fix that avoids the problem. The
> other patches are streamlining and improvements after the fix.
>
> Thanks,
> Nick
>
> Nicholas Piggin (6):
> powerpc/qspinlock: Fix stale propagated yield_cpu
> powerpc/qspinlock: stop queued waiters trying to set lock sleepy
> powerpc/qspinlock: propagate owner preemptedness rather than CPU
> number
> powerpc/qspinlock: don't propagate the not-sleepy state
> powerpc/qspinlock: Propagate sleepy if previous waiter is preempted
> powerpc/qspinlock: Rename yield_propagate_owner tunable
>
> arch/powerpc/lib/qspinlock.c | 119 +++++++++++++++--------------------
> 1 file changed, 52 insertions(+), 67 deletions(-)
>
> --
> 2.42.0
>
Just a minor comment regarding patch 2.
For the series:
Reviewed-by: Nysal Jan K.A <nysal@linux.ibm.com>
next prev parent reply other threads:[~2023-10-20 10:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 12:42 [PATCH 0/6] powerpc/qspinlock: Fix yield latency bug and other Nicholas Piggin
2023-10-16 12:43 ` [PATCH 1/6] powerpc/qspinlock: Fix stale propagated yield_cpu Nicholas Piggin
2023-10-16 12:43 ` [PATCH 2/6] powerpc/qspinlock: stop queued waiters trying to set lock sleepy Nicholas Piggin
2023-10-20 9:50 ` Nysal Jan K.A.
2023-10-16 12:43 ` [PATCH 3/6] powerpc/qspinlock: propagate owner preemptedness rather than CPU number Nicholas Piggin
2023-10-16 12:43 ` [PATCH 4/6] powerpc/qspinlock: don't propagate the not-sleepy state Nicholas Piggin
2023-10-16 12:43 ` [PATCH 5/6] powerpc/qspinlock: Propagate sleepy if previous waiter is preempted Nicholas Piggin
2023-10-16 12:43 ` [PATCH 6/6] powerpc/qspinlock: Rename yield_propagate_owner tunable Nicholas Piggin
2023-10-18 7:41 ` [PATCH 0/6] powerpc/qspinlock: Fix yield latency bug and other Shrikanth Hegde
2023-10-20 10:04 ` Nysal Jan K.A. [this message]
2023-10-20 12:01 ` (subset) " Michael Ellerman
2023-10-27 9:59 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231020100429.GB213288@li-80eaad4c-2afd-11b2-a85c-af8123d033e3.ibm.com \
--to=nysal@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=npiggin@gmail.com \
--cc=srikar@linux.vnet.ibm.com \
--cc=sshegde@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.