From: Nathan Lynch via B4 Relay <devnull+nathanl.linux.ibm.com@kernel.org>
To: Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Nathan Lynch <nathanl@linux.ibm.com>, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH 4/7] powerpc/rtas: Remove unused rtas_service_present()
Date: Mon, 06 Nov 2023 07:42:56 -0600 [thread overview]
Message-ID: <20231106-rtas-trivial-v1-4-61847655c51f@linux.ibm.com> (raw)
In-Reply-To: <20231106-rtas-trivial-v1-0-61847655c51f@linux.ibm.com>
From: Nathan Lynch <nathanl@linux.ibm.com>
rtas_service_present() has no more users.
rtas_function_implemented() is now the appropriate API for determining
whether a given RTAS function is available to call.
Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
---
arch/powerpc/include/asm/rtas.h | 1 -
arch/powerpc/kernel/rtas.c | 5 -----
2 files changed, 6 deletions(-)
diff --git a/arch/powerpc/include/asm/rtas.h b/arch/powerpc/include/asm/rtas.h
index 3bf7f0a4b07e..c6568a647cd0 100644
--- a/arch/powerpc/include/asm/rtas.h
+++ b/arch/powerpc/include/asm/rtas.h
@@ -409,7 +409,6 @@ static inline bool rtas_function_implemented(const rtas_fn_handle_t handle)
return rtas_function_token(handle) != RTAS_UNKNOWN_SERVICE;
}
extern int rtas_token(const char *service);
-extern int rtas_service_present(const char *service);
extern int rtas_call(int token, int, int, int *, ...);
void rtas_call_unlocked(struct rtas_args *args, int token, int nargs,
int nret, ...);
diff --git a/arch/powerpc/kernel/rtas.c b/arch/powerpc/kernel/rtas.c
index eddc031c4b95..b5b340a91157 100644
--- a/arch/powerpc/kernel/rtas.c
+++ b/arch/powerpc/kernel/rtas.c
@@ -900,11 +900,6 @@ int rtas_token(const char *service)
}
EXPORT_SYMBOL_GPL(rtas_token);
-int rtas_service_present(const char *service)
-{
- return rtas_token(service) != RTAS_UNKNOWN_SERVICE;
-}
-
#ifdef CONFIG_RTAS_ERROR_LOGGING
static u32 rtas_error_log_max __ro_after_init = RTAS_ERROR_LOG_MAX;
--
2.41.0
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Lynch <nathanl@linux.ibm.com>
To: Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: linuxppc-dev@lists.ozlabs.org, Nathan Lynch <nathanl@linux.ibm.com>
Subject: [PATCH 4/7] powerpc/rtas: Remove unused rtas_service_present()
Date: Mon, 06 Nov 2023 07:42:56 -0600 [thread overview]
Message-ID: <20231106-rtas-trivial-v1-4-61847655c51f@linux.ibm.com> (raw)
In-Reply-To: <20231106-rtas-trivial-v1-0-61847655c51f@linux.ibm.com>
rtas_service_present() has no more users.
rtas_function_implemented() is now the appropriate API for determining
whether a given RTAS function is available to call.
Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
---
arch/powerpc/include/asm/rtas.h | 1 -
arch/powerpc/kernel/rtas.c | 5 -----
2 files changed, 6 deletions(-)
diff --git a/arch/powerpc/include/asm/rtas.h b/arch/powerpc/include/asm/rtas.h
index 3bf7f0a4b07e..c6568a647cd0 100644
--- a/arch/powerpc/include/asm/rtas.h
+++ b/arch/powerpc/include/asm/rtas.h
@@ -409,7 +409,6 @@ static inline bool rtas_function_implemented(const rtas_fn_handle_t handle)
return rtas_function_token(handle) != RTAS_UNKNOWN_SERVICE;
}
extern int rtas_token(const char *service);
-extern int rtas_service_present(const char *service);
extern int rtas_call(int token, int, int, int *, ...);
void rtas_call_unlocked(struct rtas_args *args, int token, int nargs,
int nret, ...);
diff --git a/arch/powerpc/kernel/rtas.c b/arch/powerpc/kernel/rtas.c
index eddc031c4b95..b5b340a91157 100644
--- a/arch/powerpc/kernel/rtas.c
+++ b/arch/powerpc/kernel/rtas.c
@@ -900,11 +900,6 @@ int rtas_token(const char *service)
}
EXPORT_SYMBOL_GPL(rtas_token);
-int rtas_service_present(const char *service)
-{
- return rtas_token(service) != RTAS_UNKNOWN_SERVICE;
-}
-
#ifdef CONFIG_RTAS_ERROR_LOGGING
static u32 rtas_error_log_max __ro_after_init = RTAS_ERROR_LOG_MAX;
--
2.41.0
next prev parent reply other threads:[~2023-11-06 13:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-06 13:42 [PATCH 0/7] powerpc/rtas: Trivial, coding style, and kernel-doc fixes Nathan Lynch
2023-11-06 13:42 ` Nathan Lynch via B4 Relay
2023-11-06 13:42 ` [PATCH 1/7] powerpc/pseries/rtas-work-area: Fix rtas_work_area_reserve_arena() kernel-doc Nathan Lynch via B4 Relay
2023-11-06 13:42 ` Nathan Lynch
2023-11-06 13:42 ` [PATCH 2/7] powerpc/rtas: Fix ppc_rtas_rmo_buf_show() kernel-doc Nathan Lynch via B4 Relay
2023-11-06 13:42 ` Nathan Lynch
2023-11-06 13:42 ` [PATCH 3/7] powerpc/rtas: Drop declaration of undefined call_rtas() function Nathan Lynch
2023-11-06 13:42 ` Nathan Lynch via B4 Relay
2023-11-06 13:42 ` Nathan Lynch via B4 Relay [this message]
2023-11-06 13:42 ` [PATCH 4/7] powerpc/rtas: Remove unused rtas_service_present() Nathan Lynch
2023-11-06 13:42 ` [PATCH 5/7] powerpc/rtas: Move post_mobility_fixup() declaration to pseries Nathan Lynch
2023-11-06 13:42 ` Nathan Lynch via B4 Relay
2023-11-06 13:42 ` [PATCH 6/7] powerpc/rtas: Remove trailing space Nathan Lynch via B4 Relay
2023-11-06 13:42 ` Nathan Lynch
2023-11-06 13:42 ` [PATCH 7/7] powerpc/rtas: Remove 'extern' from function declarations in rtas.h Nathan Lynch via B4 Relay
2023-11-06 13:42 ` Nathan Lynch
2023-11-13 2:45 ` (subset) [PATCH 0/7] powerpc/rtas: Trivial, coding style, and kernel-doc fixes Michael Ellerman
2023-12-07 12:38 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231106-rtas-trivial-v1-4-61847655c51f@linux.ibm.com \
--to=devnull+nathanl.linux.ibm.com@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nathanl@linux.ibm.com \
--cc=npiggin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.