From: kernel test robot <lkp@intel.com>
To: Rouven Czerwinski <r.czerwinski@pengutronix.de>,
Josua Mayer <josua@solid-run.com>,
Johannes Berg <johannes.berg@intel.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
kernel@pengutronix.de,
Rouven Czerwinski <r.czerwinski@pengutronix.de>,
stable@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH] net: rfkill: gpio: set GPIO direction
Date: Thu, 7 Dec 2023 05:41:51 +0800 [thread overview]
Message-ID: <202312070522.71CNBJ25-lkp@intel.com> (raw)
In-Reply-To: <20231206131336.3099727-1-r.czerwinski@pengutronix.de>
Hi Rouven,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 994d5c58e50e91bb02c7be4a91d5186292a895c8]
url: https://github.com/intel-lab-lkp/linux/commits/Rouven-Czerwinski/net-rfkill-gpio-set-GPIO-direction/20231206-211525
base: 994d5c58e50e91bb02c7be4a91d5186292a895c8
patch link: https://lore.kernel.org/r/20231206131336.3099727-1-r.czerwinski%40pengutronix.de
patch subject: [PATCH] net: rfkill: gpio: set GPIO direction
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20231207/202312070522.71CNBJ25-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231207/202312070522.71CNBJ25-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312070522.71CNBJ25-lkp@intel.com/
All warnings (new ones prefixed by >>):
>> net/rfkill/rfkill-gpio.c:129:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized]
129 | if (rfkill->reset_gpio)
| ^~~~~~~~~~~~~~~~~~
net/rfkill/rfkill-gpio.c:131:6: note: uninitialized use occurs here
131 | if (ret)
| ^~~
net/rfkill/rfkill-gpio.c:129:2: note: remove the 'if' if its condition is always true
129 | if (rfkill->reset_gpio)
| ^~~~~~~~~~~~~~~~~~~~~~~
130 | ret = gpiod_direction_output(rfkill->reset_gpio, true);
| ~~~~~~~~~~~~~~~~
net/rfkill/rfkill-gpio.c:82:9: note: initialize the variable 'ret' to silence this warning
82 | int ret;
| ^
| = 0
1 warning generated.
vim +129 net/rfkill/rfkill-gpio.c
74
75 static int rfkill_gpio_probe(struct platform_device *pdev)
76 {
77 struct rfkill_gpio_data *rfkill;
78 struct gpio_desc *gpio;
79 const char *name_property;
80 const char *type_property;
81 const char *type_name;
82 int ret;
83
84 rfkill = devm_kzalloc(&pdev->dev, sizeof(*rfkill), GFP_KERNEL);
85 if (!rfkill)
86 return -ENOMEM;
87
88 if (dev_of_node(&pdev->dev)) {
89 name_property = "label";
90 type_property = "radio-type";
91 } else {
92 name_property = "name";
93 type_property = "type";
94 }
95 device_property_read_string(&pdev->dev, name_property, &rfkill->name);
96 device_property_read_string(&pdev->dev, type_property, &type_name);
97
98 if (!rfkill->name)
99 rfkill->name = dev_name(&pdev->dev);
100
101 rfkill->type = rfkill_find_type(type_name);
102
103 if (ACPI_HANDLE(&pdev->dev)) {
104 ret = rfkill_gpio_acpi_probe(&pdev->dev, rfkill);
105 if (ret)
106 return ret;
107 }
108
109 rfkill->clk = devm_clk_get(&pdev->dev, NULL);
110
111 gpio = devm_gpiod_get_optional(&pdev->dev, "reset", GPIOD_ASIS);
112 if (IS_ERR(gpio))
113 return PTR_ERR(gpio);
114
115 rfkill->reset_gpio = gpio;
116
117 gpio = devm_gpiod_get_optional(&pdev->dev, "shutdown", GPIOD_ASIS);
118 if (IS_ERR(gpio))
119 return PTR_ERR(gpio);
120
121 rfkill->shutdown_gpio = gpio;
122
123 /* Make sure at-least one GPIO is defined for this instance */
124 if (!rfkill->reset_gpio && !rfkill->shutdown_gpio) {
125 dev_err(&pdev->dev, "invalid platform data\n");
126 return -EINVAL;
127 }
128
> 129 if (rfkill->reset_gpio)
130 ret = gpiod_direction_output(rfkill->reset_gpio, true);
131 if (ret)
132 return ret;
133
134 if (rfkill->shutdown_gpio)
135 ret = gpiod_direction_output(rfkill->shutdown_gpio, true);
136 if (ret)
137 return ret;
138
139 rfkill->rfkill_dev = rfkill_alloc(rfkill->name, &pdev->dev,
140 rfkill->type, &rfkill_gpio_ops,
141 rfkill);
142 if (!rfkill->rfkill_dev)
143 return -ENOMEM;
144
145 ret = rfkill_register(rfkill->rfkill_dev);
146 if (ret < 0)
147 goto err_destroy;
148
149 platform_set_drvdata(pdev, rfkill);
150
151 dev_info(&pdev->dev, "%s device registered.\n", rfkill->name);
152
153 return 0;
154
155 err_destroy:
156 rfkill_destroy(rfkill->rfkill_dev);
157
158 return ret;
159 }
160
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2023-12-06 21:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 13:13 [PATCH] net: rfkill: gpio: set GPIO direction Rouven Czerwinski
2023-12-06 13:16 ` Johannes Berg
2023-12-06 13:24 ` Rouven Czerwinski
2023-12-06 14:35 ` Philipp Zabel
2023-12-06 21:41 ` kernel test robot [this message]
2023-12-07 7:58 ` [PATCH v2] " Rouven Czerwinski
2023-12-12 9:54 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202312070522.71CNBJ25-lkp@intel.com \
--to=lkp@intel.com \
--cc=edumazet@google.com \
--cc=johannes.berg@intel.com \
--cc=josua@solid-run.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=pabeni@redhat.com \
--cc=r.czerwinski@pengutronix.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.