All of lore.kernel.org
 help / color / mirror / Atom feed
From: Su Hui <suhui@nfschina.com>
To: pkshih@realtek.com, kvalo@kernel.org
Cc: Su Hui <suhui@nfschina.com>,
	Larry.Finger@lwfinger.net, linville@tuxdriver.com,
	george0505@realtek.com, chaoming_li@realsil.com.cn,
	linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel-janitors@vger.kernel.org
Subject: [PATCH wireless-next 00/11] using calculate_bit_shift() to fix undefined bitwise shift behavior.
Date: Tue, 19 Dec 2023 14:57:28 +0800	[thread overview]
Message-ID: <20231219065739.1895666-1-suhui@nfschina.com> (raw)

There is an undefined bitwise shift behavior, when the right operand is
greater than or equal to then width of the  promoted left operand.
(eg: (u32)data << 32). Commit bc8263083af6("fix an undefined bitwise shift
behavior") only fixed one problem, there are many similar problems in 
drivers/net/wireless/realtek/. 

This patchset adds a new function calculate_bit_shift() to fix the
remaining undefined bitwise shift behavior problems.(Compile tested only)

Su Hui (11):
  wifi: rtlwifi: add calculate_bit_shift()
  wifi: rtlwifi: rtl8821ae: phy: using calculate_bit_shift()
  wifi: rtlwifi: rtl8188ee: phy: using calculate_bit_shift()
  wifi: rtlwifi: rtl8192c: using calculate_bit_shift()
  wifi: rtlwifi: rtl8192cu: using calculate_bit_shift()
  wifi: rtlwifi: rtl8192ce: using calculate_bit_shift()
  wifi: rtlwifi: rtl8192de: using calculate_bit_shift()
  wifi: rtlwifi: rtl8192ee: using calculate_bit_shift()
  wifi: rtlwifi: rtl8192se: using calculate_bit_shift()
  wifi: rtlwifi: rtl8723_common: using calculate_bit_shift()
  wifi: rtlwifi: rtl8723{be,ae}: using calculate_bit_shift()

 .../net/wireless/realtek/rtlwifi/rtl8188ee/phy.c | 14 ++++----------
 .../realtek/rtlwifi/rtl8192c/phy_common.c        | 12 ++----------
 .../realtek/rtlwifi/rtl8192c/phy_common.h        |  1 -
 .../net/wireless/realtek/rtlwifi/rtl8192ce/phy.c |  6 +++---
 .../net/wireless/realtek/rtlwifi/rtl8192ce/phy.h |  1 -
 .../net/wireless/realtek/rtlwifi/rtl8192cu/phy.c |  6 +++---
 .../net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 15 ++++-----------
 .../net/wireless/realtek/rtlwifi/rtl8192ee/phy.c | 16 ++++------------
 .../net/wireless/realtek/rtlwifi/rtl8192se/phy.c | 15 ++++-----------
 .../net/wireless/realtek/rtlwifi/rtl8723ae/phy.c |  6 +++---
 .../net/wireless/realtek/rtlwifi/rtl8723be/phy.c |  4 ++--
 .../realtek/rtlwifi/rtl8723com/phy_common.c      | 12 ++----------
 .../realtek/rtlwifi/rtl8723com/phy_common.h      |  1 -
 .../net/wireless/realtek/rtlwifi/rtl8821ae/phy.c | 15 ++++-----------
 drivers/net/wireless/realtek/rtlwifi/wifi.h      |  7 +++++++
 15 files changed, 42 insertions(+), 89 deletions(-)

-- 
2.30.2


             reply	other threads:[~2023-12-19  6:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-19  6:57 Su Hui [this message]
2023-12-19  6:57 ` [PATCH wireless-next 01/11] wifi: rtlwifi: add calculate_bit_shift() Su Hui
2023-12-20  6:47   ` Ping-Ke Shih
2023-12-21 14:40   ` Kalle Valo
2023-12-19  6:57 ` [PATCH wireless-next 02/11] wifi: rtlwifi: rtl8821ae: phy: using calculate_bit_shift() Su Hui
2023-12-19  6:57 ` [PATCH wireless-next 03/11] wifi: rtlwifi: rtl8188ee: " Su Hui
2023-12-19  6:57 ` [PATCH wireless-next 04/11] wifi: rtlwifi: rtl8192c: " Su Hui
2023-12-19  6:57 ` [PATCH wireless-next 05/11] wifi: rtlwifi: rtl8192cu: " Su Hui
2023-12-19  6:57 ` [PATCH wireless-next 06/11] wifi: rtlwifi: rtl8192ce: " Su Hui
2023-12-19  6:57 ` [PATCH wireless-next 07/11] wifi: rtlwifi: rtl8192de: " Su Hui
2023-12-19  6:57 ` [PATCH wireless-next 08/11] wifi: rtlwifi: rtl8192ee: " Su Hui
2023-12-19  6:57 ` [PATCH wireless-next 09/11] wifi: rtlwifi: rtl8192se: " Su Hui
2023-12-19  6:57 ` [PATCH wireless-next 10/11] wifi: rtlwifi: rtl8723_common: " Su Hui
2023-12-19  6:57 ` [PATCH wireless-next 11/11] wifi: rtlwifi: rtl8723{be,ae}: " Su Hui

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231219065739.1895666-1-suhui@nfschina.com \
    --to=suhui@nfschina.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=chaoming_li@realsil.com.cn \
    --cc=george0505@realtek.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=pkshih@realtek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.