From: Johan Hovold <johan+linaro@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH v5 0/4] ASoC: qcom: volume fixes and codec cleanups
Date: Mon, 22 Jan 2024 19:18:15 +0100 [thread overview]
Message-ID: <20240122181819.4038-1-johan+linaro@kernel.org> (raw)
To reduce the risk of speaker damage the PA gain needs to be limited on
machines like the Lenovo Thinkpad X13s until we have active speaker
protection in place.
Limit the gain to the current default setting provided by the UCM
configuration which most user have so far been using (due to a bug in
the configuration files which prevented hardware volume control [1]).
The wsa883x PA volume control also turned out to be broken, which meant
that the default setting used by UCM configuration is actually the
lowest level (-3 dB). With the codec driver fixed, hardware volume
control also works as expected.
Note that the new wsa884x driver most likely suffers from a similar bug,
I'll send a fix for that once I've got that confirmed.
Included is also a related fix for the LPASS WSA macro driver, which
was changing the digital gain setting behind the back of user space and
which can result in excessive (or too low) digital gain.
There are further Qualcomm codec drivers that similarly appear to
manipulate various gain settings, but on closer inspection it turns out
that they only write back the current settings. Tests reveal that these
writes are indeed needed for any prior updates to take effect (at least
for the WSA and RX macros).
Johan
[1] https://github.com/alsa-project/alsa-ucm-conf/pull/382
Changes in v5
- rebase on v6.8-rc1
Changes in v4
- keep the full PA volume control range and only fix the exported dB
values
- use a combined -3 dB machine limit as limiting just the PA volume
confuses PulseAudio
- drop the PA gain initialisation which is no longer needed
Changes in v3
- fix the wsa883x PA volume control and update the machine limits
accordingly
Changes in v2
- keep the volume register write on power-on in lpass-wsa-macro
- drop the other patches removing volume register writes on DAPM events
- only drop the constant-zero gain offsets in wcd9335
Johan Hovold (4):
ASoC: codecs: wsa883x: fix PA volume control
ASoC: qcom: sc8280xp: limit speaker volumes
ASoC: codecs: lpass-wsa-macro: fix compander volume hack
ASoC: codecs: wcd9335: drop unused gain hack remnant
sound/soc/codecs/lpass-wsa-macro.c | 7 -------
sound/soc/codecs/wcd9335.c | 4 ----
sound/soc/codecs/wsa883x.c | 6 +++++-
sound/soc/qcom/sc8280xp.c | 12 +++++++-----
4 files changed, 12 insertions(+), 17 deletions(-)
--
2.43.0
next reply other threads:[~2024-01-22 18:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-22 18:18 Johan Hovold [this message]
2024-01-22 18:18 ` [PATCH v5 1/4] ASoC: codecs: wsa883x: fix PA volume control Johan Hovold
2024-01-22 18:18 ` [PATCH v5 2/4] ASoC: qcom: sc8280xp: limit speaker volumes Johan Hovold
2024-01-22 18:18 ` [PATCH v5 3/4] ASoC: codecs: lpass-wsa-macro: fix compander volume hack Johan Hovold
2024-01-22 18:18 ` [PATCH v5 4/4] ASoC: codecs: wcd9335: drop unused gain hack remnant Johan Hovold
2024-01-22 21:54 ` (subset) [PATCH v5 0/4] ASoC: qcom: volume fixes and codec cleanups Mark Brown
2024-01-30 12:53 ` Johan Hovold
2024-02-03 8:36 ` Stable backport request (was: [PATCH v5 0/4] ASoC: qcom: volume fixes and codec cleanups) Johan Hovold
2024-02-03 16:04 ` Greg Kroah-Hartman
2024-02-03 17:02 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240122181819.4038-1-johan+linaro@kernel.org \
--to=johan+linaro@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.