From: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
To: <ath12k@lists.infradead.org>
Cc: <linux-wireless@vger.kernel.org>,
Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
Subject: [PATCH v3 04/13] wifi: ath12k: fix fetching MCBC flag for QCN9274
Date: Mon, 29 Jan 2024 12:27:15 +0530 [thread overview]
Message-ID: <20240129065724.2310207-5-quic_rajkbhag@quicinc.com> (raw)
In-Reply-To: <20240129065724.2310207-1-quic_rajkbhag@quicinc.com>
In QCN9274, RX packet's multicast and broadcast(MCBC) flag is fetched
from RX descriptor's msdu_end info5 member but it is not correct
for QCN9274. Due to this with encryption, ARP request packet is wrongly
marked as MCBC packet and it is sent to mac80211 without setting
RX_FLAG_PN_VALIDATED & RX_FLAG_DECRYPTED flag. This results in packet
getting dropped in mac80211. Hence ping initiated from station to AP
fails.
Fix this by fetching correct MCBC flag in case of QCN9274.
For QC9274 MCBC flag should be fetched from RX descriptor's mpdu_start
info6 member.
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00188-QCAHKSWPL_SILICONZ-1
Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.0.1-00029-QCAHKSWPL_SILICONZ-1
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3
Fixes: 8f04852e90cb ("wifi: ath12k: Use msdu_end to check MCBC")
Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@quicinc.com>
---
drivers/net/wireless/ath/ath12k/hal.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath12k/hal.c b/drivers/net/wireless/ath/ath12k/hal.c
index a489369d8068..1bdab8604db9 100644
--- a/drivers/net/wireless/ath/ath12k/hal.c
+++ b/drivers/net/wireless/ath/ath12k/hal.c
@@ -1,7 +1,7 @@
// SPDX-License-Identifier: BSD-3-Clause-Clear
/*
* Copyright (c) 2018-2021 The Linux Foundation. All rights reserved.
- * Copyright (c) 2021-2023 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2021-2024 Qualcomm Innovation Center, Inc. All rights reserved.
*/
#include <linux/dma-mapping.h>
#include "hal_tx.h"
@@ -449,8 +449,8 @@ static u8 *ath12k_hw_qcn9274_rx_desc_mpdu_start_addr2(struct hal_rx_desc *desc)
static bool ath12k_hw_qcn9274_rx_desc_is_da_mcbc(struct hal_rx_desc *desc)
{
- return __le16_to_cpu(desc->u.qcn9274.msdu_end.info5) &
- RX_MSDU_END_INFO5_DA_IS_MCBC;
+ return __le32_to_cpu(desc->u.qcn9274.mpdu_start.info6) &
+ RX_MPDU_START_INFO6_MCAST_BCAST;
}
static void ath12k_hw_qcn9274_rx_desc_get_dot11_hdr(struct hal_rx_desc *desc,
--
2.34.1
next prev parent reply other threads:[~2024-01-29 6:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 6:57 [PATCH v3 00/13] wifi: ath12k: QCN9274 dualmac bring up Raj Kumar Bhagat
2024-01-29 6:57 ` [PATCH v3 01/13] wifi: ath12k: indicate NON MBSSID vdev by default during vdev start Raj Kumar Bhagat
2024-01-31 21:04 ` Jeff Johnson
2024-02-02 12:33 ` Kalle Valo
2024-01-29 6:57 ` [PATCH v3 02/13] wifi: ath12k: fetch correct pdev id from WMI_SERVICE_READY_EXT_EVENTID Raj Kumar Bhagat
2024-01-31 21:05 ` Jeff Johnson
2024-01-29 6:57 ` [PATCH v3 03/13] wifi: ath12k: add support for peer meta data version Raj Kumar Bhagat
2024-01-31 21:05 ` Jeff Johnson
2024-01-29 6:57 ` Raj Kumar Bhagat [this message]
2024-01-31 21:06 ` [PATCH v3 04/13] wifi: ath12k: fix fetching MCBC flag for QCN9274 Jeff Johnson
2024-01-29 6:57 ` [PATCH v3 05/13] wifi: ath12k: Add logic to write QRTR node id to scratch Raj Kumar Bhagat
2024-01-31 21:06 ` Jeff Johnson
2024-02-02 12:20 ` Kalle Valo
2024-02-02 14:32 ` Raj Kumar Bhagat
2024-01-29 6:57 ` [PATCH v3 06/13] wifi: ath12k: fix firmware assert during insmod in memory segment mode Raj Kumar Bhagat
2024-01-31 21:06 ` Jeff Johnson
2024-01-29 6:57 ` [PATCH v3 07/13] wifi: ath12k: split hal_ops to support RX TLVs word mask compaction Raj Kumar Bhagat
2024-01-31 21:07 ` Jeff Johnson
2024-01-29 6:57 ` [PATCH v3 08/13] wifi: ath12k: remove hal_desc_sz from hw params Raj Kumar Bhagat
2024-01-31 21:07 ` Jeff Johnson
2024-01-29 6:57 ` [PATCH v3 09/13] wifi: ath12k: subscribe required word mask from rx tlv Raj Kumar Bhagat
2024-01-31 21:07 ` Jeff Johnson
2024-02-02 12:27 ` Kalle Valo
2024-02-02 14:28 ` Raj Kumar Bhagat
2024-01-29 6:57 ` [PATCH v3 10/13] wifi: ath12k: add MAC id support in WBM error path Raj Kumar Bhagat
2024-01-31 21:08 ` Jeff Johnson
2024-01-29 6:57 ` [PATCH v3 11/13] wifi: ath12k: fix PCI read and write Raj Kumar Bhagat
2024-01-31 21:08 ` Jeff Johnson
2024-01-29 6:57 ` [PATCH v3 12/13] wifi: ath12k: Read board id to support split-PHY QCN9274 Raj Kumar Bhagat
2024-01-31 21:09 ` Jeff Johnson
2024-02-14 14:17 ` Sven Eckelmann
2024-02-15 11:32 ` Kalle Valo
2024-01-29 6:57 ` [PATCH v3 13/13] wifi: ath12k: disable QMI PHY capability learn in split-phy QCN9274 Raj Kumar Bhagat
2024-01-30 1:52 ` Jeff Johnson
2024-01-30 3:04 ` Raj Kumar Bhagat
2024-01-31 21:08 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240129065724.2310207-5-quic_rajkbhag@quicinc.com \
--to=quic_rajkbhag@quicinc.com \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.