From: kernel test robot <lkp@intel.com>
To: Miri Korenblit <miriam.rachel.korenblit@intel.com>,
johannes@sipsolutions.net
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
linux-wireless@vger.kernel.org,
Shaul Triebitz <shaul.triebitz@intel.com>
Subject: Re: [PATCH 09/11] wifi: iwlwifi: iwlmvm: handle unprotected deauth/disassoc in d3
Date: Wed, 7 Feb 2024 14:27:41 +0800 [thread overview]
Message-ID: <202402071449.LObxtopc-lkp@intel.com> (raw)
In-Reply-To: <20240206175739.fde438a22e3f.I3c8497520aaa95a22febff727b0ad08146965d47@changeid>
Hi Miri,
kernel test robot noticed the following build errors:
[auto build test ERROR on wireless-next/main]
[also build test ERROR on next-20240206]
[cannot apply to wireless/main linus/master v6.8-rc3]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Miri-Korenblit/wifi-iwlwifi-mvm-fix-a-crash-when-we-run-out-of-stations/20240207-000459
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link: https://lore.kernel.org/r/20240206175739.fde438a22e3f.I3c8497520aaa95a22febff727b0ad08146965d47%40changeid
patch subject: [PATCH 09/11] wifi: iwlwifi: iwlmvm: handle unprotected deauth/disassoc in d3
config: powerpc-randconfig-001-20240207 (https://download.01.org/0day-ci/archive/20240207/202402071449.LObxtopc-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 7dd790db8b77c4a833c06632e903dc4f13877a64)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240207/202402071449.LObxtopc-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402071449.LObxtopc-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/net/wireless/intel/iwlwifi/mvm/d3.c:1518:10: error: no member named 'unprot_deauth_disassoc' in 'struct cfg80211_wowlan_wakeup'
1518 | wakeup.unprot_deauth_disassoc = true;
| ~~~~~~ ^
1 error generated.
vim +1518 drivers/net/wireless/intel/iwlwifi/mvm/d3.c
1465
1466 static void iwl_mvm_report_wakeup_reasons(struct iwl_mvm *mvm,
1467 struct ieee80211_vif *vif,
1468 struct iwl_wowlan_status_data *status)
1469 {
1470 struct sk_buff *pkt = NULL;
1471 struct cfg80211_wowlan_wakeup wakeup = {
1472 .pattern_idx = -1,
1473 };
1474 struct cfg80211_wowlan_wakeup *wakeup_report = &wakeup;
1475 u32 reasons = status->wakeup_reasons;
1476
1477 if (reasons == IWL_WOWLAN_WAKEUP_BY_NON_WIRELESS) {
1478 wakeup_report = NULL;
1479 goto report;
1480 }
1481
1482 pm_wakeup_event(mvm->dev, 0);
1483
1484 if (reasons & IWL_WOWLAN_WAKEUP_BY_MAGIC_PACKET)
1485 wakeup.magic_pkt = true;
1486
1487 if (reasons & IWL_WOWLAN_WAKEUP_BY_PATTERN)
1488 wakeup.pattern_idx =
1489 status->pattern_number;
1490
1491 if (reasons & (IWL_WOWLAN_WAKEUP_BY_DISCONNECTION_ON_MISSED_BEACON |
1492 IWL_WOWLAN_WAKEUP_BY_DISCONNECTION_ON_DEAUTH |
1493 IWL_WOWLAN_WAKEUP_BY_GTK_REKEY_FAILURE))
1494 wakeup.disconnect = true;
1495
1496 if (reasons & IWL_WOWLAN_WAKEUP_BY_GTK_REKEY_FAILURE)
1497 wakeup.gtk_rekey_failure = true;
1498
1499 if (reasons & IWL_WOWLAN_WAKEUP_BY_RFKILL_DEASSERTED)
1500 wakeup.rfkill_release = true;
1501
1502 if (reasons & IWL_WOWLAN_WAKEUP_BY_EAPOL_REQUEST)
1503 wakeup.eap_identity_req = true;
1504
1505 if (reasons & IWL_WOWLAN_WAKEUP_BY_FOUR_WAY_HANDSHAKE)
1506 wakeup.four_way_handshake = true;
1507
1508 if (reasons & IWL_WOWLAN_WAKEUP_BY_REM_WAKE_LINK_LOSS)
1509 wakeup.tcp_connlost = true;
1510
1511 if (reasons & IWL_WOWLAN_WAKEUP_BY_REM_WAKE_SIGNATURE_TABLE)
1512 wakeup.tcp_nomoretokens = true;
1513
1514 if (reasons & IWL_WOWLAN_WAKEUP_BY_REM_WAKE_WAKEUP_PACKET)
1515 wakeup.tcp_match = true;
1516
1517 if (reasons & IWL_WAKEUP_BY_11W_UNPROTECTED_DEAUTH_OR_DISASSOC)
> 1518 wakeup.unprot_deauth_disassoc = true;
1519
1520 if (status->wake_packet) {
1521 int pktsize = status->wake_packet_bufsize;
1522 int pktlen = status->wake_packet_length;
1523 const u8 *pktdata = status->wake_packet;
1524 const struct ieee80211_hdr *hdr = (const void *)pktdata;
1525 int truncated = pktlen - pktsize;
1526
1527 /* this would be a firmware bug */
1528 if (WARN_ON_ONCE(truncated < 0))
1529 truncated = 0;
1530
1531 if (ieee80211_is_data(hdr->frame_control)) {
1532 int hdrlen = ieee80211_hdrlen(hdr->frame_control);
1533 int ivlen = 0, icvlen = 4; /* also FCS */
1534
1535 pkt = alloc_skb(pktsize, GFP_KERNEL);
1536 if (!pkt)
1537 goto report;
1538
1539 skb_put_data(pkt, pktdata, hdrlen);
1540 pktdata += hdrlen;
1541 pktsize -= hdrlen;
1542
1543 if (ieee80211_has_protected(hdr->frame_control)) {
1544 /*
1545 * This is unlocked and using gtk_i(c)vlen,
1546 * but since everything is under RTNL still
1547 * that's not really a problem - changing
1548 * it would be difficult.
1549 */
1550 if (is_multicast_ether_addr(hdr->addr1)) {
1551 ivlen = mvm->gtk_ivlen;
1552 icvlen += mvm->gtk_icvlen;
1553 } else {
1554 ivlen = mvm->ptk_ivlen;
1555 icvlen += mvm->ptk_icvlen;
1556 }
1557 }
1558
1559 /* if truncated, FCS/ICV is (partially) gone */
1560 if (truncated >= icvlen) {
1561 icvlen = 0;
1562 truncated -= icvlen;
1563 } else {
1564 icvlen -= truncated;
1565 truncated = 0;
1566 }
1567
1568 pktsize -= ivlen + icvlen;
1569 pktdata += ivlen;
1570
1571 skb_put_data(pkt, pktdata, pktsize);
1572
1573 if (ieee80211_data_to_8023(pkt, vif->addr, vif->type))
1574 goto report;
1575 wakeup.packet = pkt->data;
1576 wakeup.packet_present_len = pkt->len;
1577 wakeup.packet_len = pkt->len - truncated;
1578 wakeup.packet_80211 = false;
1579 } else {
1580 int fcslen = 4;
1581
1582 if (truncated >= 4) {
1583 truncated -= 4;
1584 fcslen = 0;
1585 } else {
1586 fcslen -= truncated;
1587 truncated = 0;
1588 }
1589 pktsize -= fcslen;
1590 wakeup.packet = status->wake_packet;
1591 wakeup.packet_present_len = pktsize;
1592 wakeup.packet_len = pktlen - truncated;
1593 wakeup.packet_80211 = true;
1594 }
1595 }
1596
1597 report:
1598 ieee80211_report_wowlan_wakeup(vif, wakeup_report, GFP_KERNEL);
1599 kfree_skb(pkt);
1600 }
1601
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-02-07 6:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 16:02 [PATCH 00/11] wifi: iwlwifi: updates - 2024-02-06 Miri Korenblit
2024-02-06 16:02 ` [PATCH 01/11] wifi: iwlwifi: mvm: fix a crash when we run out of stations Miri Korenblit
2024-02-06 16:02 ` [PATCH 02/11] wifi: iwlwifi: fw: allow vmalloc for PNVM image Miri Korenblit
2024-02-06 16:02 ` [PATCH 03/11] wifi: iwlwifi: mvm: don't set the MFP flag for the GTK Miri Korenblit
2024-02-06 16:02 ` [PATCH 04/11] wifi: iwlwifi: mvm: don't send the smart fifo command if not needed Miri Korenblit
2024-02-06 16:02 ` [PATCH 05/11] wifi: iwlwifi: pcie: Add new PCI device id and CNVI Miri Korenblit
2024-02-06 16:02 ` [PATCH 06/11] wifi: iwlwifi: mvm: don't set replay counters to 0xff Miri Korenblit
2024-02-06 16:02 ` [PATCH 07/11] wifi: iwlwifi: mvm: remove flags for enable/disable beacon filter Miri Korenblit
2024-02-06 16:02 ` [PATCH 08/11] wifi: iwlwifi: mvm: show skb_mac_gso_segment() failure reason Miri Korenblit
2024-02-06 16:02 ` [PATCH 09/11] wifi: iwlwifi: iwlmvm: handle unprotected deauth/disassoc in d3 Miri Korenblit
2024-02-07 3:39 ` kernel test robot
2024-02-07 6:27 ` kernel test robot [this message]
2024-02-06 16:02 ` [PATCH 10/11] wifi: iwlwifi: mvm: move BA notif messages before action Miri Korenblit
2024-02-06 16:02 ` [PATCH 11/11] wifi: iwlwifi: queue: improve warning for no skb in reclaim Miri Korenblit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202402071449.LObxtopc-lkp@intel.com \
--to=lkp@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=miriam.rachel.korenblit@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=shaul.triebitz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.