From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: Venkata Prasad Potturu <venkataprasad.potturu@amd.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>
Cc: sound-open-firmware@alsa-project.org,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH v3 1/2] ASoC: SOF: amd: Move signed_fw_image to struct acp_quirk_entry
Date: Wed, 21 Feb 2024 10:55:51 +0200 [thread overview]
Message-ID: <22cb4ca8-7114-4162-b4a4-ded70d2a69d1@collabora.com> (raw)
In-Reply-To: <133770ce-98b0-4e36-b21e-1468c45fad0e@amd.com>
On 2/21/24 08:14, Venkata Prasad Potturu wrote:
>
> On 2/21/24 01:46, Cristian Ciocaltea wrote:
>> The signed_fw_image member of struct sof_amd_acp_desc is used to enable
>> signed firmware support in the driver via the acp_sof_quirk_table.
>>
>> In preparation to support additional use cases of the quirk table (i.e.
>> adding new flags), move signed_fw_image to a new struct acp_quirk_entry
>> and update all references to it accordingly.
>>
>> No functional changes intended.
>
> If there are no new flags currently being used in this patch, and also
> no functional changes added, in this case this patch is really required?
I would say yes, as it improves the ACP SOF quirk handling by making the
implementation more readable, less error prone and open for extension,
as already mentioned.
Additionally, it should facilitate the review process, since it's
unaffected by any potential changes that might be required for the
subsequent patch.
> Also please use scripts/get_maintainer.pl in CC while sending patches,
> then only
> maintainers get notified your changes.
I've already done that. Did I miss something?
Regards,
Cristian
next prev parent reply other threads:[~2024-02-21 8:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-20 20:16 [PATCH v3 0/2] ASoC: SOF: amd: Skip IRAM/DRAM size modification for Steam Deck OLED Cristian Ciocaltea
2024-02-20 20:16 ` [PATCH v3 1/2] ASoC: SOF: amd: Move signed_fw_image to struct acp_quirk_entry Cristian Ciocaltea
2024-02-21 6:14 ` Venkata Prasad Potturu
2024-02-21 8:55 ` Cristian Ciocaltea [this message]
2024-02-21 7:28 ` Venkata Prasad Potturu
2024-02-21 9:35 ` AngeloGioacchino Del Regno
2024-02-21 10:29 ` Cristian Ciocaltea
2024-02-21 10:35 ` AngeloGioacchino Del Regno
2024-02-21 10:59 ` Cristian Ciocaltea
2024-02-20 20:16 ` [PATCH v3 2/2] ASoC: SOF: amd: Skip IRAM/DRAM size modification for Steam Deck OLED Cristian Ciocaltea
2024-03-04 19:11 ` [PATCH v3 0/2] " Cristian Ciocaltea
2024-03-04 19:12 ` Mark Brown
2024-03-15 22:04 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22cb4ca8-7114-4162-b4a4-ded70d2a69d1@collabora.com \
--to=cristian.ciocaltea@collabora.com \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kernel@collabora.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=venkataprasad.potturu@amd.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.