From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Hans de Goede <hdegoede@redhat.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Peter Ujfalusi <peter.ujfalusi@linux.intel.com>,
Mark Brown <broonie@kernel.org>
Cc: Oder Chiou <oder_chiou@realtek.com>, alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/2] ASoC: rt5645: Make LattePanda board DMI match more precise
Date: Mon, 12 Feb 2024 08:51:28 -0600 [thread overview]
Message-ID: <2f2d814f-61fe-490c-83ae-e397eddfdc17@linux.intel.com> (raw)
In-Reply-To: <20240211212736.179605-1-hdegoede@redhat.com>
On 2/11/24 15:27, Hans de Goede wrote:
> The DMI strings used for the LattePanda board DMI quirks are very generic.
>
> Using the dmidecode database from https://linux-hardware.org/ shows
> that the chosen DMI strings also match the following 2 laptops
> which also have a rt5645 codec:
>
> Insignia NS-P11W7100 https://linux-hardware.org/?computer=E092FFF8BA04
> Insignia NS-P10W8100 https://linux-hardware.org/?computer=AFB6C0BF7934
>
> All 4 hw revisions of the LattePanda board have "S70CR" in their BIOS
> version DMI strings:
>
> DF-BI-7-S70CR100-*
> DF-BI-7-S70CR110-*
> DF-BI-7-S70CR200-*
> LP-BS-7-S70CR700-*
>
> See e.g. https://linux-hardware.org/?computer=D98250A817C0
>
> Add a partial (non exact) DMI match on this string to make the LattePanda
> board DMI match more precise to avoid false-positive matches.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
For patch1 and 2
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
next prev parent reply other threads:[~2024-02-12 14:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-11 21:27 [PATCH 1/2] ASoC: rt5645: Make LattePanda board DMI match more precise Hans de Goede
2024-02-11 21:27 ` [PATCH 2/2] ASoC: rt5645: Add DMI quirk for inverted jack-detect on MeeGoPad T8 Hans de Goede
2024-02-12 14:51 ` Pierre-Louis Bossart [this message]
2024-02-12 15:32 ` [PATCH 1/2] ASoC: rt5645: Make LattePanda board DMI match more precise Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f2d814f-61fe-490c-83ae-e397eddfdc17@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=peter.ujfalusi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.