From: "Arnd Bergmann" <arnd@arndb.de>
To: "Arend van Spriel" <arend.vanspriel@broadcom.com>,
"Kalle Valo" <kvalo@kernel.org>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: "Nathan Chancellor" <nathan@kernel.org>,
"Greg Kroah-Hartman" <gregkh@suse.de>,
"Pieter-Paul Giesberts" <pieterpg@broadcom.com>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
"Artem Chernyshev" <artem.chernyshev@red-soft.ru>,
"Jonas Gorski" <jonas.gorski@gmail.com>,
linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
brcm80211-dev-list.pdl@broadcom.com,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: [PATCH] brcmsmac: avoid function pointer casts
Date: Wed, 14 Feb 2024 16:07:00 +0100 [thread overview]
Message-ID: <3f1c2d5a-ba98-4ae5-a7a0-0328b7552113@app.fastmail.com> (raw)
In-Reply-To: <fd36f032-3bf6-4cae-a0d0-213604cef024@broadcom.com>
On Wed, Feb 14, 2024, at 10:23, Arend van Spriel wrote:
> On 2/14/2024 9:45 AM, Kalle Valo wrote:
>> Arnd Bergmann <arnd@kernel.org> wrote:
>>
>>> From: Arnd Bergmann <arnd@arndb.de>
>>>
>>> An old cleanup went a little too far and causes a warning with clang-16
>>> and higher as it breaks control flow integrity (KCFI) rules:
>>>
>>> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy_shim.c:64:34: error: cast from 'void (*)(struct brcms_phy *)' to 'void (*)(void *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict]
>>> 64 | brcms_init_timer(physhim->wl, (void (*)(void *))fn,
>>> | ^~~~~~~~~~~~~~~~~~~~
>>>
>>> Change this one instance back to passing a void pointer so it can be
>>> used with the timer callback interface.
>>>
>>> Fixes: d89a4c80601d ("staging: brcm80211: removed void * from softmac phy")
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> I guess this should go to wireless tree?
>
> This has been like this forever looking at the "staging" part in the
> Fixes tag. Is it really so urgent now? On the other hand I have no real
> problem with moving this to the wireless tree. Just wondering out loud.
It's probably fine either way. Some maintainers like to backport
the warning fixes to stable kernels, others don't. Since the
warning is currently only enabled at W=1 level, it's probably fine
to fix it for linux-next only, but if we want the fix backported,
it should also go into 6.8.
Arnd
next prev parent reply other threads:[~2024-02-14 15:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 10:05 [PATCH] brcmsmac: avoid function pointer casts Arnd Bergmann
2024-02-14 8:45 ` Kalle Valo
2024-02-14 9:23 ` Arend van Spriel
2024-02-14 15:07 ` Arnd Bergmann [this message]
2024-02-14 17:55 ` Kalle Valo
2024-02-15 10:33 ` Kalle Valo
2024-02-15 13:48 ` Arend Van Spriel
2024-02-16 15:49 ` wifi: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f1c2d5a-ba98-4ae5-a7a0-0328b7552113@app.fastmail.com \
--to=arnd@arndb.de \
--cc=arend.vanspriel@broadcom.com \
--cc=arnd@kernel.org \
--cc=artem.chernyshev@red-soft.ru \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=gregkh@suse.de \
--cc=jonas.gorski@gmail.com \
--cc=justinstitt@google.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=pieterpg@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.