From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH 1/3] ASoC: codecs: wcd938x: handle deferred probe
Date: Wed, 17 Jan 2024 17:59:07 +0100 [thread overview]
Message-ID: <72988b7c-8a04-4bab-9341-9a0c9fae2ea5@linaro.org> (raw)
In-Reply-To: <8c30a417-20fb-4d61-b5e5-deb5cd579e50@sirena.org.uk>
On 17/01/2024 16:22, Mark Brown wrote:
> On Wed, Jan 17, 2024 at 04:12:06PM +0100, Krzysztof Kozlowski wrote:
>
>> if (ret) {
>> dev_err(dev, "%s: Fail to obtain platform data\n", __func__);
>> - return -EINVAL;
>> + return ret;
>
> Should this be a dev_err_probe() as well?
It should be just dropped, which I do in the next patch. Errors are
already printed in called wcd938x_populate_dt_data() (with
dev_err_probe). However I decided to split them, as only this one is a
candidate for backport, IMO. Feel free to squash the next (2/3) into
this one.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-01-17 16:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-17 15:12 [PATCH 1/3] ASoC: codecs: wcd938x: handle deferred probe Krzysztof Kozlowski
2024-01-17 15:12 ` [PATCH 2/3] ASoC: codecs: wcd938x: skip printing deferred probe failuers Krzysztof Kozlowski
2024-01-17 15:12 ` [PATCH 3/3] ASoC: codecs: wcd934x: drop unneeded regulator include Krzysztof Kozlowski
2024-01-17 15:22 ` [PATCH 1/3] ASoC: codecs: wcd938x: handle deferred probe Mark Brown
2024-01-17 16:59 ` Krzysztof Kozlowski [this message]
2024-01-22 20:44 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72988b7c-8a04-4bab-9341-9a0c9fae2ea5@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
--cc=stable@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.