From: Johan Hovold <johan@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Johan Hovold <johan+linaro@kernel.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Banajit Goswami <bgoswami@quicinc.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, linux-sound@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 0/4] ASoC: qcom: volume fixes and codec cleanups
Date: Tue, 23 Jan 2024 08:58:20 +0100 [thread overview]
Message-ID: <Za9xnEXYczA5rsw3@hovoldconsulting.com> (raw)
In-Reply-To: <170596045016.161959.16318695944363636291.b4-ty@kernel.org>
On Mon, Jan 22, 2024 at 09:54:10PM +0000, Mark Brown wrote:
> On Fri, 19 Jan 2024 12:24:16 +0100, Johan Hovold wrote:
> > To reduce the risk of speaker damage the PA gain needs to be limited on
> > machines like the Lenovo Thinkpad X13s until we have active speaker
> > protection in place.
> >
> > Limit the gain to the current default setting provided by the UCM
> > configuration which most user have so far been using (due to a bug in
> > the configuration files which prevented hardware volume control [1]).
> >
> > [...]
>
> Applied to
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
>
> Thanks!
>
> [1/4] ASoC: codecs: wsa883x: fix PA volume control
> (no commit info)
> [2/4] ASoC: qcom: sc8280xp: limit speaker volumes
> commit: c481016bb4f8a9c059c39ac06e7b65e233a61f6a
> [3/4] ASoC: codecs: lpass-wsa-macro: fix compander volume hack
> (no commit info)
> [4/4] ASoC: codecs: wcd9335: drop unused gain hack remnant
> (no commit info)
Thanks, Mark.
Could you consider applying at least patches 1/4 and 3/4 for 6.8 as
well?
The former is needed for proper hardware volume control with the fixed
UCM files, and the latter avoids ending up with the digital gain setting
set too low or too high while by-passing the volume limit set by the
machine driver.
Johan
next prev parent reply other threads:[~2024-01-23 7:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 11:24 [PATCH v4 0/4] ASoC: qcom: volume fixes and codec cleanups Johan Hovold
2024-01-19 11:24 ` [PATCH v4 1/4] ASoC: codecs: wsa883x: fix PA volume control Johan Hovold
2024-01-19 11:24 ` [PATCH v4 2/4] ASoC: qcom: sc8280xp: limit speaker volumes Johan Hovold
2024-01-19 15:26 ` Johan Hovold
2024-01-22 0:03 ` Mark Brown
2024-01-22 7:41 ` Johan Hovold
2024-01-22 16:05 ` Mark Brown
2024-01-22 17:29 ` Johan Hovold
2024-01-22 18:06 ` Mark Brown
2024-01-22 18:21 ` Johan Hovold
2024-01-19 11:24 ` [PATCH v4 3/4] ASoC: codecs: lpass-wsa-macro: fix compander volume hack Johan Hovold
2024-01-19 11:24 ` [PATCH v4 4/4] ASoC: codecs: wcd9335: drop unused gain hack remnant Johan Hovold
2024-01-22 21:54 ` [PATCH v4 0/4] ASoC: qcom: volume fixes and codec cleanups Mark Brown
2024-01-23 7:58 ` Johan Hovold [this message]
2024-01-23 13:05 ` Mark Brown
2024-01-23 13:30 ` Johan Hovold
2024-01-23 13:57 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Za9xnEXYczA5rsw3@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.