From: Christophe Leroy <christophe.leroy@csgroup.eu>
To: Michael Ellerman <mpe@ellerman.id.au>,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] powerpc/mm: Allow ARCH_FORCE_MAX_ORDER up to 12
Date: Wed, 11 Oct 2023 13:40:10 +0000 [thread overview]
Message-ID: <bcee34d6-a0ad-c144-6132-b3848259351d@csgroup.eu> (raw)
In-Reply-To: <20230824122849.942072-1-mpe@ellerman.id.au>
Le 24/08/2023 à 14:28, Michael Ellerman a écrit :
> Christophe reported that the change to ARCH_FORCE_MAX_ORDER to limit the
> range to 10 had broken his ability to configure hugepages:
>
> # echo 1 > /sys/kernel/mm/hugepages/hugepages-8192kB/nr_hugepages
> sh: write error: Invalid argument
>
> Several of the powerpc defconfigs previously set the
> ARCH_FORCE_MAX_ORDER value to 12, via the definition in
> arch/powerpc/configs/fsl-emb-nonhw.config, used by:
>
> mpc85xx_defconfig
> mpc85xx_smp_defconfig
> corenet32_smp_defconfig
> corenet64_smp_defconfig
> mpc86xx_defconfig
> mpc86xx_smp_defconfig
>
> Fix it by increasing the allowed range to 12 to restore the previous
> behaviour.
>
> Fixes: 358e526a1648 ("powerpc/mm: Reinstate ARCH_FORCE_MAX_ORDER ranges")
> Reported-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> Link: https://msgid.link/id:8011d806-5b30-bf26-2bfe-a08c39d57e20@csgroup.eu
> ---
> arch/powerpc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Christophe, can you confirm this fixes your system?
It works, thanks.
Tested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
>
> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index c831e20cf40f..8977fa73c09e 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig
> @@ -928,7 +928,7 @@ config ARCH_FORCE_MAX_ORDER
> default "6" if PPC32 && PPC_64K_PAGES
> range 4 10 if PPC32 && PPC_256K_PAGES
> default "4" if PPC32 && PPC_256K_PAGES
> - range 10 10
> + range 10 12
> default "10"
> help
> The kernel page allocator limits the size of maximal physically
next prev parent reply other threads:[~2023-10-11 13:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 12:28 [PATCH] powerpc/mm: Allow ARCH_FORCE_MAX_ORDER up to 12 Michael Ellerman
2023-10-11 13:40 ` Christophe Leroy [this message]
2023-10-15 10:00 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcee34d6-a0ad-c144-6132-b3848259351d@csgroup.eu \
--to=christophe.leroy@csgroup.eu \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.