All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiawei Wang <me@jwang.link>
To: broonie@kernel.org
Cc: linux-sound@vger.kernel.org, me@jwang.link, sashal@kernel.org,
	vijendar.mukunda@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Mario Limonciello <mario.limonciello@amd.com>,
	Jeremy Soller <jeremy@system76.com>,
	August Wikerfors <git@augustwikerfors.se>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v3 1/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2"
Date: Wed, 13 Mar 2024 09:58:52 +0800	[thread overview]
Message-ID: <20240313015853.3573242-2-me@jwang.link> (raw)
In-Reply-To: <20240313015853.3573242-1-me@jwang.link>

This reverts commit ed00a6945dc32462c2d3744a3518d2316da66fcc,
which added a quirk entry to enable the Yellow Carp (YC)
driver for the Lenovo 21J2 laptop.

Although the microphone functioned with the YC driver, it
resulted in incorrect driver usage. The Lenovo 21J2 is not a
Yellow Carp platform, but a Pink Sardine platform, which
already has an upstreamed driver.

The microphone on the Lenovo 21J2 operates correctly with the
CONFIG_SND_SOC_AMD_PS flag enabled and does not require the
quirk entry. So this patch removes the quirk entry.

Thanks to Mukunda Vijendar [1] for pointing this out.

Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1]

Signed-off-by: Jiawei Wang <me@jwang.link>
---
 sound/soc/amd/yc/acp6x-mach.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/sound/soc/amd/yc/acp6x-mach.c b/sound/soc/amd/yc/acp6x-mach.c
index 1ab69a53174e..69c68d8e7a6b 100644
--- a/sound/soc/amd/yc/acp6x-mach.c
+++ b/sound/soc/amd/yc/acp6x-mach.c
@@ -199,13 +199,6 @@ static const struct dmi_system_id yc_acp_quirk_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "21HY"),
 		}
 	},
-	{
-		.driver_data = &acp6x_card,
-		.matches = {
-			DMI_MATCH(DMI_BOARD_VENDOR, "LENOVO"),
-			DMI_MATCH(DMI_PRODUCT_NAME, "21J2"),
-		}
-	},
 	{
 		.driver_data = &acp6x_card,
 		.matches = {
-- 
2.39.2


  reply	other threads:[~2024-03-13  2:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12  2:33 [PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support" Jiawei Wang
2024-03-12  2:33 ` [PATCH 1/2] Revert "ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2" Jiawei Wang
2024-03-12 13:56   ` Mark Brown
2024-03-12 16:32     ` [PATCH v2 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support" Jiawei Wang
2024-03-12 16:32       ` [PATCH v2 1/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" Jiawei Wang
2024-03-12 16:44         ` Mark Brown
2024-03-13  1:58           ` [PATCH v3 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support" Jiawei Wang
2024-03-13  1:58             ` Jiawei Wang [this message]
2024-03-13  1:58             ` [PATCH v3 2/2] ASoC: amd: yc: Revert " Jiawei Wang
2024-03-14  5:14             ` [PATCH v3 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and " Mukunda,Vijendar
2024-03-14 13:09               ` Mark Brown
2024-03-15 17:14             ` Mark Brown
2024-03-12 16:32       ` [PATCH v2 2/2] ASoC: amd: yc: Revert " Jiawei Wang
2024-03-15 17:14       ` [PATCH v2 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and " Mark Brown
2024-03-12  2:33 ` [PATCH 2/2] Revert "ASoC: amd: yc: add " Jiawei Wang
2024-03-12 13:14 ` [PATCH 0/2] " Mark Brown
2024-03-27 17:56 ` Luca Stefani
2024-03-27 18:09   ` Greg KH
2024-03-28 10:40     ` Mukunda,Vijendar
2024-03-28 11:34       ` Greg KH
2024-03-28 11:57         ` Mukunda,Vijendar
2024-03-29  9:30           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240313015853.3573242-2-me@jwang.link \
    --to=me@jwang.link \
    --cc=broonie@kernel.org \
    --cc=git@augustwikerfors.se \
    --cc=jeremy@system76.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=mario.limonciello@amd.com \
    --cc=perex@perex.cz \
    --cc=sashal@kernel.org \
    --cc=tiwai@suse.com \
    --cc=vijendar.mukunda@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.