All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiawei Wang <me@jwang.link>
To: broonie@kernel.org
Cc: linux-sound@vger.kernel.org, me@jwang.link, sashal@kernel.org,
	vijendar.mukunda@amd.com, Liam Girdwood <lgirdwood@gmail.com>,
	Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
	Syed Saba Kareem <Syed.SabaKareem@amd.com>,
	Vijendar Mukunda <Vijendar.Mukunda@amd.com>,
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH v3 2/2] ASoC: amd: yc: Revert "add new YC platform variant (0x63) support"
Date: Wed, 13 Mar 2024 09:58:53 +0800	[thread overview]
Message-ID: <20240313015853.3573242-3-me@jwang.link> (raw)
In-Reply-To: <20240313015853.3573242-1-me@jwang.link>

This reverts commit 316a784839b21b122e1761cdca54677bb19a47fa,
that enabled Yellow Carp (YC) driver for PCI revision id 0x63.

Mukunda Vijendar [1] points out that revision 0x63 is Pink
Sardine platform, not Yellow Carp. The YC driver should not
be enabled for this platform. This patch prevents the YC
driver from being incorrectly enabled.

Link: https://lore.kernel.org/linux-sound/023092e1-689c-4b00-b93f-4092c3724fb6@amd.com/ [1]

Signed-off-by: Jiawei Wang <me@jwang.link>
---
 sound/soc/amd/yc/pci-acp6x.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/sound/soc/amd/yc/pci-acp6x.c b/sound/soc/amd/yc/pci-acp6x.c
index 694b8e313902..7af6a349b1d4 100644
--- a/sound/soc/amd/yc/pci-acp6x.c
+++ b/sound/soc/amd/yc/pci-acp6x.c
@@ -162,7 +162,6 @@ static int snd_acp6x_probe(struct pci_dev *pci,
 	/* Yellow Carp device check */
 	switch (pci->revision) {
 	case 0x60:
-	case 0x63:
 	case 0x6f:
 		break;
 	default:
-- 
2.39.2


  parent reply	other threads:[~2024-03-13  2:00 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-12  2:33 [PATCH 0/2] Revert "ASoC: amd: yc: add new YC platform variant (0x63) support" Jiawei Wang
2024-03-12  2:33 ` [PATCH 1/2] Revert "ASoC: amd: yc: Fix non-functional mic on Lenovo 21J2" Jiawei Wang
2024-03-12 13:56   ` Mark Brown
2024-03-12 16:32     ` [PATCH v2 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support" Jiawei Wang
2024-03-12 16:32       ` [PATCH v2 1/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" Jiawei Wang
2024-03-12 16:44         ` Mark Brown
2024-03-13  1:58           ` [PATCH v3 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support" Jiawei Wang
2024-03-13  1:58             ` [PATCH v3 1/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" Jiawei Wang
2024-03-13  1:58             ` Jiawei Wang [this message]
2024-03-14  5:14             ` [PATCH v3 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and "add new YC platform variant (0x63) support" Mukunda,Vijendar
2024-03-14 13:09               ` Mark Brown
2024-03-15 17:14             ` Mark Brown
2024-03-12 16:32       ` [PATCH v2 2/2] ASoC: amd: yc: Revert " Jiawei Wang
2024-03-15 17:14       ` [PATCH v2 0/2] ASoC: amd: yc: Revert "Fix non-functional mic on Lenovo 21J2" and " Mark Brown
2024-03-12  2:33 ` [PATCH 2/2] Revert "ASoC: amd: yc: add " Jiawei Wang
2024-03-12 13:14 ` [PATCH 0/2] " Mark Brown
2024-03-27 17:56 ` Luca Stefani
2024-03-27 18:09   ` Greg KH
2024-03-28 10:40     ` Mukunda,Vijendar
2024-03-28 11:34       ` Greg KH
2024-03-28 11:57         ` Mukunda,Vijendar
2024-03-29  9:30           ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240313015853.3573242-3-me@jwang.link \
    --to=me@jwang.link \
    --cc=Syed.SabaKareem@amd.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=sashal@kernel.org \
    --cc=tiwai@suse.com \
    --cc=vijendar.mukunda@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.