From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
bpf@vger.kernel.org, Hari Bathini <hbathini@linux.ibm.com>
Cc: "Naveen N. Rao" <naveen.n.rao@linux.ibm.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Song Liu <songliubraving@fb.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v2] powerpc/bpf: populate extable entries only during the last pass
Date: Mon, 03 Jul 2023 15:21:16 +1000 [thread overview]
Message-ID: <168836167606.46386.1266997701169825170.b4-ty@ellerman.id.au> (raw)
In-Reply-To: <20230425065829.18189-1-hbathini@linux.ibm.com>
On Tue, 25 Apr 2023 12:28:29 +0530, Hari Bathini wrote:
> Since commit 85e031154c7c ("powerpc/bpf: Perform complete extra passes
> to update addresses"), two additional passes are performed to avoid
> space and CPU time wastage on powerpc. But these extra passes led to
> WARN_ON_ONCE() hits in bpf_add_extable_entry() as extable entries are
> populated again, during the extra pass, without resetting the index.
> Fix it by resetting entry index before repopulating extable entries,
> if and when there is an additional pass.
>
> [...]
Applied to powerpc/fixes.
[1/1] powerpc/bpf: populate extable entries only during the last pass
https://git.kernel.org/powerpc/c/35a4b8ce4ac00e940b46b1034916ccb22ce9bdef
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <patch-notifications@ellerman.id.au>
To: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
bpf@vger.kernel.org, Hari Bathini <hbathini@linux.ibm.com>
Cc: Song Liu <songliubraving@fb.com>,
Daniel Borkmann <daniel@iogearbox.net>,
Alexei Starovoitov <ast@kernel.org>,
Andrii Nakryiko <andrii@kernel.org>,
stable@vger.kernel.org,
"Naveen N. Rao" <naveen.n.rao@linux.ibm.com>
Subject: Re: [PATCH v2] powerpc/bpf: populate extable entries only during the last pass
Date: Mon, 03 Jul 2023 15:21:16 +1000 [thread overview]
Message-ID: <168836167606.46386.1266997701169825170.b4-ty@ellerman.id.au> (raw)
In-Reply-To: <20230425065829.18189-1-hbathini@linux.ibm.com>
On Tue, 25 Apr 2023 12:28:29 +0530, Hari Bathini wrote:
> Since commit 85e031154c7c ("powerpc/bpf: Perform complete extra passes
> to update addresses"), two additional passes are performed to avoid
> space and CPU time wastage on powerpc. But these extra passes led to
> WARN_ON_ONCE() hits in bpf_add_extable_entry() as extable entries are
> populated again, during the extra pass, without resetting the index.
> Fix it by resetting entry index before repopulating extable entries,
> if and when there is an additional pass.
>
> [...]
Applied to powerpc/fixes.
[1/1] powerpc/bpf: populate extable entries only during the last pass
https://git.kernel.org/powerpc/c/35a4b8ce4ac00e940b46b1034916ccb22ce9bdef
cheers
next prev parent reply other threads:[~2023-07-03 5:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 6:58 [PATCH v2] powerpc/bpf: populate extable entries only during the last pass Hari Bathini
2023-04-25 6:58 ` Hari Bathini
2023-04-25 14:36 ` Naveen N. Rao
2023-04-25 14:36 ` Naveen N. Rao
2023-07-03 5:21 ` Michael Ellerman [this message]
2023-07-03 5:21 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168836167606.46386.1266997701169825170.b4-ty@ellerman.id.au \
--to=patch-notifications@ellerman.id.au \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=daniel@iogearbox.net \
--cc=hbathini@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=naveen.n.rao@linux.ibm.com \
--cc=songliubraving@fb.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.