From: Conor Dooley <conor@kernel.org> To: Chen-Yu Tsai <wens@kernel.org> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Vinod Koul <vkoul@kernel.org>, Chen-Yu Tsai <wens@csie.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-sound@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/7] dt-bindings: dma: allwinner,sun50i-a64-dma: Add compatible for H616 Date: Sun, 28 Jan 2024 11:52:11 +0000 [thread overview] Message-ID: <20240128-lumber-turban-a32709039bca@spud> (raw) In-Reply-To: <20240127163247.384439-5-wens@kernel.org> [-- Attachment #1: Type: text/plain, Size: 1895 bytes --] On Sun, Jan 28, 2024 at 12:32:44AM +0800, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai <wens@csie.org> > > The DMA controllers found on the H616 and H618 are the same as the one > found on the A100. The only difference is the DMA endpoint (DRQ) layout. > > Since the number of channels and endpoints are described with additional > generic properties, just add a new H616-specific compatible string and > fallback to the A100 one. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. > --- > Changes since v1: > - Switch to "contains" for if-properties statement > - Fall back to A100 instead of H6 > > .../bindings/dma/allwinner,sun50i-a64-dma.yaml | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml > index ec2d7a789ffe..0f2501f72cca 100644 > --- a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml > +++ b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml > @@ -28,6 +28,9 @@ properties: > - items: > - const: allwinner,sun8i-r40-dma > - const: allwinner,sun50i-a64-dma > + - items: > + - const: allwinner,sun50i-h616-dma > + - const: allwinner,sun50i-a100-dma > > reg: > maxItems: 1 > @@ -59,10 +62,11 @@ required: > if: > properties: > compatible: > - enum: > - - allwinner,sun20i-d1-dma > - - allwinner,sun50i-a100-dma > - - allwinner,sun50i-h6-dma > + contains: > + enum: > + - allwinner,sun20i-d1-dma > + - allwinner,sun50i-a100-dma > + - allwinner,sun50i-h6-dma > > then: > properties: > -- > 2.39.2 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org> To: Chen-Yu Tsai <wens@kernel.org> Cc: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Jernej Skrabec <jernej.skrabec@gmail.com>, Samuel Holland <samuel@sholland.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Vinod Koul <vkoul@kernel.org>, Chen-Yu Tsai <wens@csie.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-sound@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/7] dt-bindings: dma: allwinner,sun50i-a64-dma: Add compatible for H616 Date: Sun, 28 Jan 2024 11:52:11 +0000 [thread overview] Message-ID: <20240128-lumber-turban-a32709039bca@spud> (raw) In-Reply-To: <20240127163247.384439-5-wens@kernel.org> [-- Attachment #1.1: Type: text/plain, Size: 1895 bytes --] On Sun, Jan 28, 2024 at 12:32:44AM +0800, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai <wens@csie.org> > > The DMA controllers found on the H616 and H618 are the same as the one > found on the A100. The only difference is the DMA endpoint (DRQ) layout. > > Since the number of channels and endpoints are described with additional > generic properties, just add a new H616-specific compatible string and > fallback to the A100 one. > > Signed-off-by: Chen-Yu Tsai <wens@csie.org> Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. > --- > Changes since v1: > - Switch to "contains" for if-properties statement > - Fall back to A100 instead of H6 > > .../bindings/dma/allwinner,sun50i-a64-dma.yaml | 12 ++++++++---- > 1 file changed, 8 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml > index ec2d7a789ffe..0f2501f72cca 100644 > --- a/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml > +++ b/Documentation/devicetree/bindings/dma/allwinner,sun50i-a64-dma.yaml > @@ -28,6 +28,9 @@ properties: > - items: > - const: allwinner,sun8i-r40-dma > - const: allwinner,sun50i-a64-dma > + - items: > + - const: allwinner,sun50i-h616-dma > + - const: allwinner,sun50i-a100-dma > > reg: > maxItems: 1 > @@ -59,10 +62,11 @@ required: > if: > properties: > compatible: > - enum: > - - allwinner,sun20i-d1-dma > - - allwinner,sun50i-a100-dma > - - allwinner,sun50i-h6-dma > + contains: > + enum: > + - allwinner,sun20i-d1-dma > + - allwinner,sun50i-a100-dma > + - allwinner,sun50i-h6-dma > > then: > properties: > -- > 2.39.2 > [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 228 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-01-28 11:52 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-27 16:32 [PATCH v2 0/7] arm64: sun50i-h616: Add DMA and SPDIF controllers Chen-Yu Tsai 2024-01-27 16:32 ` Chen-Yu Tsai 2024-01-27 16:32 ` [PATCH v2 1/7] dt-bindings: sound: sun4i-spdif: Fix requirements for H6 Chen-Yu Tsai 2024-01-27 16:32 ` Chen-Yu Tsai 2024-01-27 16:32 ` [PATCH v2 2/7] dt-bindings: sound: sun4i-spdif: Add Allwinner H616 compatible Chen-Yu Tsai 2024-01-27 16:32 ` Chen-Yu Tsai 2024-01-27 16:32 ` [PATCH v2 3/7] ASoC: sunxi: sun4i-spdif: Add support for Allwinner H616 Chen-Yu Tsai 2024-01-27 16:32 ` Chen-Yu Tsai 2024-01-27 16:32 ` [PATCH v2 4/7] dt-bindings: dma: allwinner,sun50i-a64-dma: Add compatible for H616 Chen-Yu Tsai 2024-01-27 16:32 ` Chen-Yu Tsai 2024-01-28 11:52 ` Conor Dooley [this message] 2024-01-28 11:52 ` Conor Dooley 2024-01-29 16:59 ` Andre Przywara 2024-01-29 16:59 ` Andre Przywara 2024-01-27 16:32 ` [PATCH v2 5/7] arm64: dts: allwinner: h6: Add RX DMA channel for SPDIF Chen-Yu Tsai 2024-01-27 16:32 ` Chen-Yu Tsai 2024-01-27 16:32 ` [PATCH v2 6/7] arm64: dts: allwinner: h616: Add DMA controller and DMA channels Chen-Yu Tsai 2024-01-27 16:32 ` Chen-Yu Tsai 2024-01-29 16:03 ` Andre Przywara 2024-01-29 16:03 ` Andre Przywara 2024-01-27 16:32 ` [PATCH v2 7/7] arm64: dts: allwinner: h616: Add SPDIF device node Chen-Yu Tsai 2024-01-27 16:32 ` Chen-Yu Tsai 2024-01-29 16:55 ` [PATCH v2 0/7] arm64: sun50i-h616: Add DMA and SPDIF controllers Mark Brown 2024-01-29 16:55 ` Mark Brown 2024-01-29 23:08 ` (subset) " Mark Brown 2024-01-29 23:08 ` Mark Brown 2024-01-30 16:50 ` Vinod Koul 2024-01-30 16:50 ` Vinod Koul 2024-01-30 19:48 ` Jernej Škrabec 2024-01-30 19:48 ` Jernej Škrabec
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240128-lumber-turban-a32709039bca@spud \ --to=conor@kernel.org \ --cc=broonie@kernel.org \ --cc=conor+dt@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=jernej.skrabec@gmail.com \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-sound@vger.kernel.org \ --cc=linux-sunxi@lists.linux.dev \ --cc=perex@perex.cz \ --cc=robh+dt@kernel.org \ --cc=samuel@sholland.org \ --cc=tiwai@suse.com \ --cc=vkoul@kernel.org \ --cc=wens@csie.org \ --cc=wens@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.