From: Nathan Lynch <nathanl@linux.ibm.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] powerpc/pseries: RTAS work area requires GENERIC_ALLOCATOR
Date: Thu, 23 Feb 2023 09:02:23 -0600 [thread overview]
Message-ID: <871qmga0hs.fsf@linux.ibm.com> (raw)
In-Reply-To: <20230223070116.660-4-rdunlap@infradead.org>
Randy Dunlap <rdunlap@infradead.org> writes:
> The RTAS work area allocator uses code that is built by
> GENERIC_ALLOCATOR, so the PSERIES Kconfig should select the
> required Kconfig symbol to fix multiple build errors.
>
> powerpc64-linux-ld: arch/powerpc/platforms/pseries/rtas-work-area.o: in function `.rtas_work_area_allocator_init':
> rtas-work-area.c:(.init.text+0x288): undefined reference to `.gen_pool_create'
> powerpc64-linux-ld: rtas-work-area.c:(.init.text+0x2dc): undefined reference to `.gen_pool_set_algo'
> powerpc64-linux-ld: rtas-work-area.c:(.init.text+0x310): undefined reference to `.gen_pool_add_owner'
> powerpc64-linux-ld: rtas-work-area.c:(.init.text+0x43c): undefined reference to `.gen_pool_destroy'
> powerpc64-linux-ld: arch/powerpc/platforms/pseries/rtas-work-area.o:(.toc+0x0): undefined reference to `gen_pool_first_fit_order_align'
> powerpc64-linux-ld: arch/powerpc/platforms/pseries/rtas-work-area.o: in function `.__rtas_work_area_alloc':
> rtas-work-area.c:(.ref.text+0x14c): undefined reference to `.gen_pool_alloc_algo_owner'
> powerpc64-linux-ld: rtas-work-area.c:(.ref.text+0x238): undefined reference to `.gen_pool_alloc_algo_owner'
> powerpc64-linux-ld: arch/powerpc/platforms/pseries/rtas-work-area.o: in function `.rtas_work_area_free':
> rtas-work-area.c:(.ref.text+0x44c): undefined reference to `.gen_pool_free_owner'
>
> Fixes: 43033bc62d34 ("powerpc/pseries: add RTAS work area allocator")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
oops. Thanks for fixing this.
Reviewed-by: Nathan Lynch <nathanl@linux.ibm.com>
WARNING: multiple messages have this Message-ID (diff)
From: Nathan Lynch <nathanl@linux.ibm.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linuxppc-dev@lists.ozlabs.org,
Nicholas Piggin <npiggin@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] powerpc/pseries: RTAS work area requires GENERIC_ALLOCATOR
Date: Thu, 23 Feb 2023 09:02:23 -0600 [thread overview]
Message-ID: <871qmga0hs.fsf@linux.ibm.com> (raw)
In-Reply-To: <20230223070116.660-4-rdunlap@infradead.org>
Randy Dunlap <rdunlap@infradead.org> writes:
> The RTAS work area allocator uses code that is built by
> GENERIC_ALLOCATOR, so the PSERIES Kconfig should select the
> required Kconfig symbol to fix multiple build errors.
>
> powerpc64-linux-ld: arch/powerpc/platforms/pseries/rtas-work-area.o: in function `.rtas_work_area_allocator_init':
> rtas-work-area.c:(.init.text+0x288): undefined reference to `.gen_pool_create'
> powerpc64-linux-ld: rtas-work-area.c:(.init.text+0x2dc): undefined reference to `.gen_pool_set_algo'
> powerpc64-linux-ld: rtas-work-area.c:(.init.text+0x310): undefined reference to `.gen_pool_add_owner'
> powerpc64-linux-ld: rtas-work-area.c:(.init.text+0x43c): undefined reference to `.gen_pool_destroy'
> powerpc64-linux-ld: arch/powerpc/platforms/pseries/rtas-work-area.o:(.toc+0x0): undefined reference to `gen_pool_first_fit_order_align'
> powerpc64-linux-ld: arch/powerpc/platforms/pseries/rtas-work-area.o: in function `.__rtas_work_area_alloc':
> rtas-work-area.c:(.ref.text+0x14c): undefined reference to `.gen_pool_alloc_algo_owner'
> powerpc64-linux-ld: rtas-work-area.c:(.ref.text+0x238): undefined reference to `.gen_pool_alloc_algo_owner'
> powerpc64-linux-ld: arch/powerpc/platforms/pseries/rtas-work-area.o: in function `.rtas_work_area_free':
> rtas-work-area.c:(.ref.text+0x44c): undefined reference to `.gen_pool_free_owner'
>
> Fixes: 43033bc62d34 ("powerpc/pseries: add RTAS work area allocator")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
oops. Thanks for fixing this.
Reviewed-by: Nathan Lynch <nathanl@linux.ibm.com>
next prev parent reply other threads:[~2023-02-23 15:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 7:01 [PATCH] POWERPC: several build fixes Randy Dunlap
2023-02-23 7:01 ` Randy Dunlap
2023-02-23 7:01 ` [PATCH 1/4] clk: mpc512x: fix resource printk format warning Randy Dunlap
2023-02-23 7:01 ` Randy Dunlap
2023-02-23 7:01 ` [PATCH 2/4] powerpc: wii: fix resource printk format warnings Randy Dunlap
2023-02-23 7:01 ` Randy Dunlap
2023-02-23 7:01 ` [PATCH 3/4] powerpc/pseries: RTAS work area requires GENERIC_ALLOCATOR Randy Dunlap
2023-02-23 7:01 ` Randy Dunlap
2023-02-23 15:02 ` Nathan Lynch [this message]
2023-02-23 15:02 ` Nathan Lynch
2023-02-23 7:01 ` [PATCH 4/4] POWERPC: sysdev/tsi108: fix resource printk format warnings Randy Dunlap
2023-02-23 7:01 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871qmga0hs.fsf@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.