From: Michael Ellerman <mpe@ellerman.id.au> To: Nathan Chancellor <nathan@kernel.org> Cc: npiggin@gmail.com, christophe.leroy@csgroup.eu, aneesh.kumar@kernel.org, naveen.n.rao@linux.ibm.com, morbo@google.com, justinstitt@google.com, linuxppc-dev@lists.ozlabs.org, patches@lists.linux.dev, llvm@lists.linux.dev, stable@vger.kernel.org Subject: Re: [PATCH] powerpc: xor_vmx: Add '-mhard-float' to CFLAGS Date: Wed, 06 Mar 2024 12:01:42 +1100 [thread overview] Message-ID: <874jdkp409.fsf@mail.lhotse> (raw) In-Reply-To: <20240305224315.GA2361659@dev-arch.thelio-3990X> Nathan Chancellor <nathan@kernel.org> writes: > Ping? We have been applying this in our CI since it was sent, it would > be nice to have this upstream soon so it can start filtering through the > stable trees. Sorry, I was away in January and missed this. Will pick it up. cheers > On Sat, Jan 27, 2024 at 11:07:43AM -0700, Nathan Chancellor wrote: >> arch/powerpc/lib/xor_vmx.o is built with '-msoft-float' (from the main >> powerpc Makefile) and '-maltivec' (from its CFLAGS), which causes an >> error when building with clang after a recent change in main: >> >> error: option '-msoft-float' cannot be specified with '-maltivec' >> make[6]: *** [scripts/Makefile.build:243: arch/powerpc/lib/xor_vmx.o] Error 1 >> >> Explicitly add '-mhard-float' before '-maltivec' in xor_vmx.o's CFLAGS >> to override the previous inclusion of '-msoft-float' (as the last option >> wins), which matches how other areas of the kernel use '-maltivec', such >> as AMDGPU. >> >> Cc: stable@vger.kernel.org >> Closes: https://github.com/ClangBuiltLinux/linux/issues/1986 >> Link: https://github.com/llvm/llvm-project/commit/4792f912b232141ecba4cbae538873be3c28556c >> Signed-off-by: Nathan Chancellor <nathan@kernel.org> >> --- >> arch/powerpc/lib/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/lib/Makefile b/arch/powerpc/lib/Makefile >> index 6eac63e79a89..0ab65eeb93ee 100644 >> --- a/arch/powerpc/lib/Makefile >> +++ b/arch/powerpc/lib/Makefile >> @@ -76,7 +76,7 @@ obj-$(CONFIG_PPC_LIB_RHEAP) += rheap.o >> obj-$(CONFIG_FTR_FIXUP_SELFTEST) += feature-fixups-test.o >> >> obj-$(CONFIG_ALTIVEC) += xor_vmx.o xor_vmx_glue.o >> -CFLAGS_xor_vmx.o += -maltivec $(call cc-option,-mabi=altivec) >> +CFLAGS_xor_vmx.o += -mhard-float -maltivec $(call cc-option,-mabi=altivec) >> # Enable <altivec.h> >> CFLAGS_xor_vmx.o += -isystem $(shell $(CC) -print-file-name=include) >> >> >> --- >> base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d >> change-id: 20240127-ppc-xor_vmx-drop-msoft-float-ad68b437f86c >> >> Best regards, >> -- >> Nathan Chancellor <nathan@kernel.org> >>
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au> To: Nathan Chancellor <nathan@kernel.org> Cc: llvm@lists.linux.dev, patches@lists.linux.dev, aneesh.kumar@kernel.org, npiggin@gmail.com, justinstitt@google.com, naveen.n.rao@linux.ibm.com, stable@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, morbo@google.com Subject: Re: [PATCH] powerpc: xor_vmx: Add '-mhard-float' to CFLAGS Date: Wed, 06 Mar 2024 12:01:42 +1100 [thread overview] Message-ID: <874jdkp409.fsf@mail.lhotse> (raw) In-Reply-To: <20240305224315.GA2361659@dev-arch.thelio-3990X> Nathan Chancellor <nathan@kernel.org> writes: > Ping? We have been applying this in our CI since it was sent, it would > be nice to have this upstream soon so it can start filtering through the > stable trees. Sorry, I was away in January and missed this. Will pick it up. cheers > On Sat, Jan 27, 2024 at 11:07:43AM -0700, Nathan Chancellor wrote: >> arch/powerpc/lib/xor_vmx.o is built with '-msoft-float' (from the main >> powerpc Makefile) and '-maltivec' (from its CFLAGS), which causes an >> error when building with clang after a recent change in main: >> >> error: option '-msoft-float' cannot be specified with '-maltivec' >> make[6]: *** [scripts/Makefile.build:243: arch/powerpc/lib/xor_vmx.o] Error 1 >> >> Explicitly add '-mhard-float' before '-maltivec' in xor_vmx.o's CFLAGS >> to override the previous inclusion of '-msoft-float' (as the last option >> wins), which matches how other areas of the kernel use '-maltivec', such >> as AMDGPU. >> >> Cc: stable@vger.kernel.org >> Closes: https://github.com/ClangBuiltLinux/linux/issues/1986 >> Link: https://github.com/llvm/llvm-project/commit/4792f912b232141ecba4cbae538873be3c28556c >> Signed-off-by: Nathan Chancellor <nathan@kernel.org> >> --- >> arch/powerpc/lib/Makefile | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/powerpc/lib/Makefile b/arch/powerpc/lib/Makefile >> index 6eac63e79a89..0ab65eeb93ee 100644 >> --- a/arch/powerpc/lib/Makefile >> +++ b/arch/powerpc/lib/Makefile >> @@ -76,7 +76,7 @@ obj-$(CONFIG_PPC_LIB_RHEAP) += rheap.o >> obj-$(CONFIG_FTR_FIXUP_SELFTEST) += feature-fixups-test.o >> >> obj-$(CONFIG_ALTIVEC) += xor_vmx.o xor_vmx_glue.o >> -CFLAGS_xor_vmx.o += -maltivec $(call cc-option,-mabi=altivec) >> +CFLAGS_xor_vmx.o += -mhard-float -maltivec $(call cc-option,-mabi=altivec) >> # Enable <altivec.h> >> CFLAGS_xor_vmx.o += -isystem $(shell $(CC) -print-file-name=include) >> >> >> --- >> base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d >> change-id: 20240127-ppc-xor_vmx-drop-msoft-float-ad68b437f86c >> >> Best regards, >> -- >> Nathan Chancellor <nathan@kernel.org> >>
next prev parent reply other threads:[~2024-03-06 1:01 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-01-27 18:07 [PATCH] powerpc: xor_vmx: Add '-mhard-float' to CFLAGS Nathan Chancellor 2024-01-27 18:07 ` Nathan Chancellor 2024-03-05 22:43 ` Nathan Chancellor 2024-03-05 22:43 ` Nathan Chancellor 2024-03-06 1:01 ` Michael Ellerman [this message] 2024-03-06 1:01 ` Michael Ellerman 2024-03-06 16:48 ` Nathan Chancellor 2024-03-06 16:48 ` Nathan Chancellor 2024-03-13 13:19 ` Michael Ellerman 2024-03-13 13:19 ` Michael Ellerman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=874jdkp409.fsf@mail.lhotse \ --to=mpe@ellerman.id.au \ --cc=aneesh.kumar@kernel.org \ --cc=christophe.leroy@csgroup.eu \ --cc=justinstitt@google.com \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=llvm@lists.linux.dev \ --cc=morbo@google.com \ --cc=nathan@kernel.org \ --cc=naveen.n.rao@linux.ibm.com \ --cc=npiggin@gmail.com \ --cc=patches@lists.linux.dev \ --cc=stable@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.