From: Michael Ellerman <mpe@ellerman.id.au> To: Christophe Leroy <christophe.leroy@csgroup.eu>, Marco Elver <elver@google.com> Cc: Dmitry Vyukov <dvyukov@google.com>, "Paul E. McKenney" <paulmck@kernel.org>, Nicholas Piggin <npiggin@gmail.com>, Chris Zankel <chris@zankel.net>, Max Filippov <jcmvbkbc@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>, "kasan-dev@googlegroups.com" <kasan-dev@googlegroups.com>, Rohan McLure <rmclure@linux.ibm.com> Subject: Re: [PATCH 1/3] kcsan: Don't expect 64 bits atomic builtins from 32 bits architectures Date: Fri, 09 Jun 2023 22:55:49 +1000 [thread overview] Message-ID: <877cschk16.fsf@mail.lhotse> (raw) In-Reply-To: <662d074e-58cf-3bde-f454-e58d04803f34@csgroup.eu> Christophe Leroy <christophe.leroy@csgroup.eu> writes: > Le 12/05/2023 à 18:09, Marco Elver a écrit : >> On Fri, 12 May 2023 at 17:31, Christophe Leroy >> <christophe.leroy@csgroup.eu> wrote: >>> >>> Activating KCSAN on a 32 bits architecture leads to the following >>> link-time failure: >>> >>> LD .tmp_vmlinux.kallsyms1 >>> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_load': >>> kernel/kcsan/core.c:1273: undefined reference to `__atomic_load_8' >>> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_store': >>> kernel/kcsan/core.c:1273: undefined reference to `__atomic_store_8' ... >>> >>> 32 bits architectures don't have 64 bits atomic builtins. Only >>> include DEFINE_TSAN_ATOMIC_OPS(64) on 64 bits architectures. >>> >>> Fixes: 0f8ad5f2e934 ("kcsan: Add support for atomic builtins") >>> Suggested-by: Marco Elver <elver@google.com> >>> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> >> >> Reviewed-by: Marco Elver <elver@google.com> >> >> Do you have your own tree to take this through with the other patches? > > I don't have my own tree but I guess that it can be taken by Michael for > 6.5 via powerpc tree with acks from you and Max. > > Michael is that ok for you ? Yeah I can take it. cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au> To: Christophe Leroy <christophe.leroy@csgroup.eu>, Marco Elver <elver@google.com> Cc: Chris Zankel <chris@zankel.net>, "Paul E. McKenney" <paulmck@kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Nicholas Piggin <npiggin@gmail.com>, Max Filippov <jcmvbkbc@gmail.com>, Rohan McLure <rmclure@linux.ibm.com>, "kasan-dev@googlegroups.com" <kasan-dev@googlegroups.com>, "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>, Dmitry Vyukov <dvyukov@google.com> Subject: Re: [PATCH 1/3] kcsan: Don't expect 64 bits atomic builtins from 32 bits architectures Date: Fri, 09 Jun 2023 22:55:49 +1000 [thread overview] Message-ID: <877cschk16.fsf@mail.lhotse> (raw) In-Reply-To: <662d074e-58cf-3bde-f454-e58d04803f34@csgroup.eu> Christophe Leroy <christophe.leroy@csgroup.eu> writes: > Le 12/05/2023 à 18:09, Marco Elver a écrit : >> On Fri, 12 May 2023 at 17:31, Christophe Leroy >> <christophe.leroy@csgroup.eu> wrote: >>> >>> Activating KCSAN on a 32 bits architecture leads to the following >>> link-time failure: >>> >>> LD .tmp_vmlinux.kallsyms1 >>> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_load': >>> kernel/kcsan/core.c:1273: undefined reference to `__atomic_load_8' >>> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_store': >>> kernel/kcsan/core.c:1273: undefined reference to `__atomic_store_8' ... >>> >>> 32 bits architectures don't have 64 bits atomic builtins. Only >>> include DEFINE_TSAN_ATOMIC_OPS(64) on 64 bits architectures. >>> >>> Fixes: 0f8ad5f2e934 ("kcsan: Add support for atomic builtins") >>> Suggested-by: Marco Elver <elver@google.com> >>> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu> >> >> Reviewed-by: Marco Elver <elver@google.com> >> >> Do you have your own tree to take this through with the other patches? > > I don't have my own tree but I guess that it can be taken by Michael for > 6.5 via powerpc tree with acks from you and Max. > > Michael is that ok for you ? Yeah I can take it. cheers
next prev parent reply other threads:[~2023-06-09 12:56 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-12 15:31 [PATCH 0/3] Extend KCSAN to all powerpc Christophe Leroy 2023-05-12 15:31 ` Christophe Leroy 2023-05-12 15:31 ` [PATCH 1/3] kcsan: Don't expect 64 bits atomic builtins from 32 bits architectures Christophe Leroy 2023-05-12 15:31 ` Christophe Leroy 2023-05-12 16:09 ` Marco Elver 2023-05-12 16:09 ` Marco Elver 2023-05-12 18:39 ` Christophe Leroy 2023-05-12 18:39 ` Christophe Leroy 2023-06-09 12:55 ` Michael Ellerman [this message] 2023-06-09 12:55 ` Michael Ellerman 2023-05-12 15:31 ` [PATCH 2/3] powerpc/{32,book3e}: kcsan: Extend KCSAN Support Christophe Leroy 2023-05-12 15:31 ` Christophe Leroy 2023-05-12 15:31 ` [PATCH 3/3] xtensa: Remove 64 bits atomic builtins stubs Christophe Leroy 2023-05-12 15:31 ` Christophe Leroy 2023-05-12 16:38 ` Max Filippov 2023-05-12 16:38 ` Max Filippov 2023-05-12 16:22 ` [PATCH 0/3] Extend KCSAN to all powerpc Marco Elver 2023-05-12 16:22 ` Marco Elver 2023-07-03 5:26 ` Michael Ellerman 2023-07-03 5:26 ` Michael Ellerman
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=877cschk16.fsf@mail.lhotse \ --to=mpe@ellerman.id.au \ --cc=chris@zankel.net \ --cc=christophe.leroy@csgroup.eu \ --cc=dvyukov@google.com \ --cc=elver@google.com \ --cc=jcmvbkbc@gmail.com \ --cc=kasan-dev@googlegroups.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=npiggin@gmail.com \ --cc=paulmck@kernel.org \ --cc=rmclure@linux.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.