From: Marco Elver <elver@google.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Dmitry Vyukov <dvyukov@google.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Chris Zankel <chris@zankel.net>,
Max Filippov <jcmvbkbc@gmail.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
kasan-dev@googlegroups.com, Rohan McLure <rmclure@linux.ibm.com>
Subject: Re: [PATCH 1/3] kcsan: Don't expect 64 bits atomic builtins from 32 bits architectures
Date: Fri, 12 May 2023 18:09:46 +0200 [thread overview]
Message-ID: <CANpmjNMm-2Tdhp6rDzA7CYvotmmGmLUnZnA_35yLUvxHB=7s0g@mail.gmail.com> (raw)
In-Reply-To: <d9c6afc28d0855240171a4e0ad9ffcdb9d07fceb.1683892665.git.christophe.leroy@csgroup.eu>
On Fri, 12 May 2023 at 17:31, Christophe Leroy
<christophe.leroy@csgroup.eu> wrote:
>
> Activating KCSAN on a 32 bits architecture leads to the following
> link-time failure:
>
> LD .tmp_vmlinux.kallsyms1
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_load':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_load_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_store':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_store_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_exchange':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_exchange_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_fetch_add':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_fetch_add_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_fetch_sub':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_fetch_sub_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_fetch_and':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_fetch_and_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_fetch_or':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_fetch_or_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_fetch_xor':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_fetch_xor_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_fetch_nand':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_fetch_nand_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_compare_exchange_strong':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_compare_exchange_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_compare_exchange_weak':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_compare_exchange_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_compare_exchange_val':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_compare_exchange_8'
>
> 32 bits architectures don't have 64 bits atomic builtins. Only
> include DEFINE_TSAN_ATOMIC_OPS(64) on 64 bits architectures.
>
> Fixes: 0f8ad5f2e934 ("kcsan: Add support for atomic builtins")
> Suggested-by: Marco Elver <elver@google.com>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: Marco Elver <elver@google.com>
Do you have your own tree to take this through with the other patches?
> ---
> kernel/kcsan/core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/kcsan/core.c b/kernel/kcsan/core.c
> index 5a60cc52adc0..8a7baf4e332e 100644
> --- a/kernel/kcsan/core.c
> +++ b/kernel/kcsan/core.c
> @@ -1270,7 +1270,9 @@ static __always_inline void kcsan_atomic_builtin_memorder(int memorder)
> DEFINE_TSAN_ATOMIC_OPS(8);
> DEFINE_TSAN_ATOMIC_OPS(16);
> DEFINE_TSAN_ATOMIC_OPS(32);
> +#ifdef CONFIG_64BIT
> DEFINE_TSAN_ATOMIC_OPS(64);
> +#endif
>
> void __tsan_atomic_thread_fence(int memorder);
> void __tsan_atomic_thread_fence(int memorder)
> --
> 2.40.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Marco Elver <elver@google.com>
To: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Chris Zankel <chris@zankel.net>,
"Paul E. McKenney" <paulmck@kernel.org>,
linux-kernel@vger.kernel.org, Nicholas Piggin <npiggin@gmail.com>,
Max Filippov <jcmvbkbc@gmail.com>,
Rohan McLure <rmclure@linux.ibm.com>,
kasan-dev@googlegroups.com, linuxppc-dev@lists.ozlabs.org,
Dmitry Vyukov <dvyukov@google.com>
Subject: Re: [PATCH 1/3] kcsan: Don't expect 64 bits atomic builtins from 32 bits architectures
Date: Fri, 12 May 2023 18:09:46 +0200 [thread overview]
Message-ID: <CANpmjNMm-2Tdhp6rDzA7CYvotmmGmLUnZnA_35yLUvxHB=7s0g@mail.gmail.com> (raw)
In-Reply-To: <d9c6afc28d0855240171a4e0ad9ffcdb9d07fceb.1683892665.git.christophe.leroy@csgroup.eu>
On Fri, 12 May 2023 at 17:31, Christophe Leroy
<christophe.leroy@csgroup.eu> wrote:
>
> Activating KCSAN on a 32 bits architecture leads to the following
> link-time failure:
>
> LD .tmp_vmlinux.kallsyms1
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_load':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_load_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_store':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_store_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_exchange':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_exchange_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_fetch_add':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_fetch_add_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_fetch_sub':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_fetch_sub_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_fetch_and':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_fetch_and_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_fetch_or':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_fetch_or_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_fetch_xor':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_fetch_xor_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_fetch_nand':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_fetch_nand_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_compare_exchange_strong':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_compare_exchange_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_compare_exchange_weak':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_compare_exchange_8'
> powerpc64-linux-ld: kernel/kcsan/core.o: in function `__tsan_atomic64_compare_exchange_val':
> kernel/kcsan/core.c:1273: undefined reference to `__atomic_compare_exchange_8'
>
> 32 bits architectures don't have 64 bits atomic builtins. Only
> include DEFINE_TSAN_ATOMIC_OPS(64) on 64 bits architectures.
>
> Fixes: 0f8ad5f2e934 ("kcsan: Add support for atomic builtins")
> Suggested-by: Marco Elver <elver@google.com>
> Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Reviewed-by: Marco Elver <elver@google.com>
Do you have your own tree to take this through with the other patches?
> ---
> kernel/kcsan/core.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/kcsan/core.c b/kernel/kcsan/core.c
> index 5a60cc52adc0..8a7baf4e332e 100644
> --- a/kernel/kcsan/core.c
> +++ b/kernel/kcsan/core.c
> @@ -1270,7 +1270,9 @@ static __always_inline void kcsan_atomic_builtin_memorder(int memorder)
> DEFINE_TSAN_ATOMIC_OPS(8);
> DEFINE_TSAN_ATOMIC_OPS(16);
> DEFINE_TSAN_ATOMIC_OPS(32);
> +#ifdef CONFIG_64BIT
> DEFINE_TSAN_ATOMIC_OPS(64);
> +#endif
>
> void __tsan_atomic_thread_fence(int memorder);
> void __tsan_atomic_thread_fence(int memorder)
> --
> 2.40.1
>
next prev parent reply other threads:[~2023-05-12 16:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 15:31 [PATCH 0/3] Extend KCSAN to all powerpc Christophe Leroy
2023-05-12 15:31 ` Christophe Leroy
2023-05-12 15:31 ` [PATCH 1/3] kcsan: Don't expect 64 bits atomic builtins from 32 bits architectures Christophe Leroy
2023-05-12 15:31 ` Christophe Leroy
2023-05-12 16:09 ` Marco Elver [this message]
2023-05-12 16:09 ` Marco Elver
2023-05-12 18:39 ` Christophe Leroy
2023-05-12 18:39 ` Christophe Leroy
2023-06-09 12:55 ` Michael Ellerman
2023-06-09 12:55 ` Michael Ellerman
2023-05-12 15:31 ` [PATCH 2/3] powerpc/{32,book3e}: kcsan: Extend KCSAN Support Christophe Leroy
2023-05-12 15:31 ` Christophe Leroy
2023-05-12 15:31 ` [PATCH 3/3] xtensa: Remove 64 bits atomic builtins stubs Christophe Leroy
2023-05-12 15:31 ` Christophe Leroy
2023-05-12 16:38 ` Max Filippov
2023-05-12 16:38 ` Max Filippov
2023-05-12 16:22 ` [PATCH 0/3] Extend KCSAN to all powerpc Marco Elver
2023-05-12 16:22 ` Marco Elver
2023-07-03 5:26 ` Michael Ellerman
2023-07-03 5:26 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANpmjNMm-2Tdhp6rDzA7CYvotmmGmLUnZnA_35yLUvxHB=7s0g@mail.gmail.com' \
--to=elver@google.com \
--cc=chris@zankel.net \
--cc=christophe.leroy@csgroup.eu \
--cc=dvyukov@google.com \
--cc=jcmvbkbc@gmail.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=npiggin@gmail.com \
--cc=paulmck@kernel.org \
--cc=rmclure@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.