From: Michael Ellerman <mpe@ellerman.id.au>
To: Masahiro Yamada <masahiroy@kernel.org>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>
Cc: Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>,
linuxppc-dev@lists.ozlabs.org,
Nathan Chancellor <nathan@kernel.org>, Tom Rix <trix@redhat.com>,
llvm@lists.linux.dev, Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc: add crtsavres.o to always-y instead of extra-y
Date: Wed, 22 Nov 2023 23:54:45 +1100 [thread overview]
Message-ID: <87a5r6j6cq.fsf@mail.lhotse> (raw)
In-Reply-To: <CAK7LNAT-_07_h1_jG606VX0WjJq8dEW+C_4E0f28mjyqFnCWFw@mail.gmail.com>
Masahiro Yamada <masahiroy@kernel.org> writes:
> On Tue, Nov 21, 2023 at 6:55 PM Aneesh Kumar K.V
> <aneesh.kumar@kernel.org> wrote:
>>
>> "Nicholas Piggin" <npiggin@gmail.com> writes:
>>
>> > On Tue Nov 21, 2023 at 9:23 AM AEST, Masahiro Yamada wrote:
>> >> crtsavres.o is linked to modules. However, as explained in commit
>> >> d0e628cd817f ("kbuild: doc: clarify the difference between extra-y
>> >> and always-y"), 'make modules' does not build extra-y.
>> >>
>> >> For example, the following command fails:
>> >>
>> >> $ make ARCH=powerpc LLVM=1 KBUILD_MODPOST_WARN=1 mrproper ps3_defconfig modules
>> >> [snip]
>> >> LD [M] arch/powerpc/platforms/cell/spufs/spufs.ko
>> >> ld.lld: error: cannot open arch/powerpc/lib/crtsavres.o: No such file or directory
>> >> make[3]: *** [scripts/Makefile.modfinal:56: arch/powerpc/platforms/cell/spufs/spufs.ko] Error 1
>> >> make[2]: *** [Makefile:1844: modules] Error 2
>> >> make[1]: *** [/home/masahiro/workspace/linux-kbuild/Makefile:350: __build_one_by_one] Error 2
>> >> make: *** [Makefile:234: __sub-make] Error 2
>> >>
>> >
>> > Thanks. Is this the correct Fixes tag?
>> >
>> > Fixes: d0e628cd817f ("powerpc/64: Do not link crtsavres.o in vmlinux")
>> >
>>
>> I am finding a different commit ID:
>>
>> commit baa25b571a168aff5a13bfdc973f1229e2b12b63
>> Author: Nicholas Piggin <npiggin@gmail.com>
>> Date: Fri May 12 01:56:49 2017 +1000
>>
>> powerpc/64: Do not link crtsavres.o in vmlinux
>>
>> The 64-bit linker creates save/restore functions on demand with final
>> links, so vmlinux does not require crtsavres.o.
>
> Yeah, I think the correct tag is:
>
> Fixes: baa25b571a16 ("powerpc/64: Do not link crtsavres.o in vmlinux")
Yep, I used that when applying.
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Masahiro Yamada <masahiroy@kernel.org>,
"Aneesh Kumar K.V" <aneesh.kumar@kernel.org>
Cc: Tom Rix <trix@redhat.com>,
llvm@lists.linux.dev, Nick Desaulniers <ndesaulniers@google.com>,
linux-kernel@vger.kernel.org,
Nathan Chancellor <nathan@kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH] powerpc: add crtsavres.o to always-y instead of extra-y
Date: Wed, 22 Nov 2023 23:54:45 +1100 [thread overview]
Message-ID: <87a5r6j6cq.fsf@mail.lhotse> (raw)
In-Reply-To: <CAK7LNAT-_07_h1_jG606VX0WjJq8dEW+C_4E0f28mjyqFnCWFw@mail.gmail.com>
Masahiro Yamada <masahiroy@kernel.org> writes:
> On Tue, Nov 21, 2023 at 6:55 PM Aneesh Kumar K.V
> <aneesh.kumar@kernel.org> wrote:
>>
>> "Nicholas Piggin" <npiggin@gmail.com> writes:
>>
>> > On Tue Nov 21, 2023 at 9:23 AM AEST, Masahiro Yamada wrote:
>> >> crtsavres.o is linked to modules. However, as explained in commit
>> >> d0e628cd817f ("kbuild: doc: clarify the difference between extra-y
>> >> and always-y"), 'make modules' does not build extra-y.
>> >>
>> >> For example, the following command fails:
>> >>
>> >> $ make ARCH=powerpc LLVM=1 KBUILD_MODPOST_WARN=1 mrproper ps3_defconfig modules
>> >> [snip]
>> >> LD [M] arch/powerpc/platforms/cell/spufs/spufs.ko
>> >> ld.lld: error: cannot open arch/powerpc/lib/crtsavres.o: No such file or directory
>> >> make[3]: *** [scripts/Makefile.modfinal:56: arch/powerpc/platforms/cell/spufs/spufs.ko] Error 1
>> >> make[2]: *** [Makefile:1844: modules] Error 2
>> >> make[1]: *** [/home/masahiro/workspace/linux-kbuild/Makefile:350: __build_one_by_one] Error 2
>> >> make: *** [Makefile:234: __sub-make] Error 2
>> >>
>> >
>> > Thanks. Is this the correct Fixes tag?
>> >
>> > Fixes: d0e628cd817f ("powerpc/64: Do not link crtsavres.o in vmlinux")
>> >
>>
>> I am finding a different commit ID:
>>
>> commit baa25b571a168aff5a13bfdc973f1229e2b12b63
>> Author: Nicholas Piggin <npiggin@gmail.com>
>> Date: Fri May 12 01:56:49 2017 +1000
>>
>> powerpc/64: Do not link crtsavres.o in vmlinux
>>
>> The 64-bit linker creates save/restore functions on demand with final
>> links, so vmlinux does not require crtsavres.o.
>
> Yeah, I think the correct tag is:
>
> Fixes: baa25b571a16 ("powerpc/64: Do not link crtsavres.o in vmlinux")
Yep, I used that when applying.
cheers
next prev parent reply other threads:[~2023-11-22 12:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-20 23:23 [PATCH] powerpc: add crtsavres.o to always-y instead of extra-y Masahiro Yamada
2023-11-20 23:23 ` Masahiro Yamada
2023-11-21 0:51 ` Nicholas Piggin
2023-11-21 0:51 ` Nicholas Piggin
2023-11-21 9:55 ` Aneesh Kumar K.V
2023-11-22 3:09 ` Masahiro Yamada
2023-11-22 3:09 ` Masahiro Yamada
2023-11-22 12:54 ` Michael Ellerman [this message]
2023-11-22 12:54 ` Michael Ellerman
2024-01-30 9:54 ` Jan Stancek
2024-01-30 9:54 ` Jan Stancek
2024-02-05 11:50 ` Michael Ellerman
2024-02-05 11:50 ` Michael Ellerman
2024-02-05 13:21 ` Jan Stancek
2024-02-05 13:21 ` Jan Stancek
2024-02-05 20:50 ` Masahiro Yamada
2024-02-05 20:50 ` Masahiro Yamada
2023-12-07 12:38 ` Michael Ellerman
2023-12-07 12:38 ` Michael Ellerman
-- strict thread matches above, loose matches on Subject: below --
2023-01-19 8:24 Masahiro Yamada
2023-01-19 8:24 ` Masahiro Yamada
2023-01-19 18:44 ` Nathan Chancellor
2023-01-19 18:44 ` Nathan Chancellor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a5r6j6cq.fsf@mail.lhotse \
--to=mpe@ellerman.id.au \
--cc=aneesh.kumar@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=npiggin@gmail.com \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.