From: "Nicholas Piggin" <npiggin@gmail.com> To: "Masahiro Yamada" <masahiroy@kernel.org>, "Michael Ellerman" <mpe@ellerman.id.au>, "Christophe Leroy" <christophe.leroy@csgroup.eu>, <linuxppc-dev@lists.ozlabs.org> Cc: "Nathan Chancellor" <nathan@kernel.org>, "Nick Desaulniers" <ndesaulniers@google.com>, "Tom Rix" <trix@redhat.com>, <linux-kernel@vger.kernel.org>, <llvm@lists.linux.dev> Subject: Re: [PATCH] powerpc: add crtsavres.o to always-y instead of extra-y Date: Tue, 21 Nov 2023 10:51:34 +1000 [thread overview] Message-ID: <CX42TU4QHS1Z.A0UUHMDAMZOL@wheely> (raw) In-Reply-To: <20231120232332.4100288-1-masahiroy@kernel.org> On Tue Nov 21, 2023 at 9:23 AM AEST, Masahiro Yamada wrote: > crtsavres.o is linked to modules. However, as explained in commit > d0e628cd817f ("kbuild: doc: clarify the difference between extra-y > and always-y"), 'make modules' does not build extra-y. > > For example, the following command fails: > > $ make ARCH=powerpc LLVM=1 KBUILD_MODPOST_WARN=1 mrproper ps3_defconfig modules > [snip] > LD [M] arch/powerpc/platforms/cell/spufs/spufs.ko > ld.lld: error: cannot open arch/powerpc/lib/crtsavres.o: No such file or directory > make[3]: *** [scripts/Makefile.modfinal:56: arch/powerpc/platforms/cell/spufs/spufs.ko] Error 1 > make[2]: *** [Makefile:1844: modules] Error 2 > make[1]: *** [/home/masahiro/workspace/linux-kbuild/Makefile:350: __build_one_by_one] Error 2 > make: *** [Makefile:234: __sub-make] Error 2 > Thanks. Is this the correct Fixes tag? Fixes: d0e628cd817f ("powerpc/64: Do not link crtsavres.o in vmlinux") Hmm, looks like LLD might just do this now automatically for us too without --save-restore-funcs (https://reviews.llvm.org/D79977). But we probably still need it for older versions, so we still need your patch. Reviewed-by: Nicholas Piggin <npiggin@gmail.com> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > arch/powerpc/lib/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/lib/Makefile b/arch/powerpc/lib/Makefile > index 51ad0397c17a..6eac63e79a89 100644 > --- a/arch/powerpc/lib/Makefile > +++ b/arch/powerpc/lib/Makefile > @@ -45,7 +45,7 @@ obj-$(CONFIG_FUNCTION_ERROR_INJECTION) += error-inject.o > # so it is only needed for modules, and only for older linkers which > # do not support --save-restore-funcs > ifndef CONFIG_LD_IS_BFD > -extra-$(CONFIG_PPC64) += crtsavres.o > +always-$(CONFIG_PPC64) += crtsavres.o > endif > > obj-$(CONFIG_PPC_BOOK3S_64) += copyuser_power7.o copypage_power7.o \
WARNING: multiple messages have this Message-ID (diff)
From: "Nicholas Piggin" <npiggin@gmail.com> To: "Masahiro Yamada" <masahiroy@kernel.org>, "Michael Ellerman" <mpe@ellerman.id.au>, "Christophe Leroy" <christophe.leroy@csgroup.eu>, <linuxppc-dev@lists.ozlabs.org> Cc: Nathan Chancellor <nathan@kernel.org>, Tom Rix <trix@redhat.com>, llvm@lists.linux.dev, Nick Desaulniers <ndesaulniers@google.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH] powerpc: add crtsavres.o to always-y instead of extra-y Date: Tue, 21 Nov 2023 10:51:34 +1000 [thread overview] Message-ID: <CX42TU4QHS1Z.A0UUHMDAMZOL@wheely> (raw) In-Reply-To: <20231120232332.4100288-1-masahiroy@kernel.org> On Tue Nov 21, 2023 at 9:23 AM AEST, Masahiro Yamada wrote: > crtsavres.o is linked to modules. However, as explained in commit > d0e628cd817f ("kbuild: doc: clarify the difference between extra-y > and always-y"), 'make modules' does not build extra-y. > > For example, the following command fails: > > $ make ARCH=powerpc LLVM=1 KBUILD_MODPOST_WARN=1 mrproper ps3_defconfig modules > [snip] > LD [M] arch/powerpc/platforms/cell/spufs/spufs.ko > ld.lld: error: cannot open arch/powerpc/lib/crtsavres.o: No such file or directory > make[3]: *** [scripts/Makefile.modfinal:56: arch/powerpc/platforms/cell/spufs/spufs.ko] Error 1 > make[2]: *** [Makefile:1844: modules] Error 2 > make[1]: *** [/home/masahiro/workspace/linux-kbuild/Makefile:350: __build_one_by_one] Error 2 > make: *** [Makefile:234: __sub-make] Error 2 > Thanks. Is this the correct Fixes tag? Fixes: d0e628cd817f ("powerpc/64: Do not link crtsavres.o in vmlinux") Hmm, looks like LLD might just do this now automatically for us too without --save-restore-funcs (https://reviews.llvm.org/D79977). But we probably still need it for older versions, so we still need your patch. Reviewed-by: Nicholas Piggin <npiggin@gmail.com> > Signed-off-by: Masahiro Yamada <masahiroy@kernel.org> > --- > > arch/powerpc/lib/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/lib/Makefile b/arch/powerpc/lib/Makefile > index 51ad0397c17a..6eac63e79a89 100644 > --- a/arch/powerpc/lib/Makefile > +++ b/arch/powerpc/lib/Makefile > @@ -45,7 +45,7 @@ obj-$(CONFIG_FUNCTION_ERROR_INJECTION) += error-inject.o > # so it is only needed for modules, and only for older linkers which > # do not support --save-restore-funcs > ifndef CONFIG_LD_IS_BFD > -extra-$(CONFIG_PPC64) += crtsavres.o > +always-$(CONFIG_PPC64) += crtsavres.o > endif > > obj-$(CONFIG_PPC_BOOK3S_64) += copyuser_power7.o copypage_power7.o \
next prev parent reply other threads:[~2023-11-21 0:51 UTC|newest] Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-11-20 23:23 [PATCH] powerpc: add crtsavres.o to always-y instead of extra-y Masahiro Yamada 2023-11-20 23:23 ` Masahiro Yamada 2023-11-21 0:51 ` Nicholas Piggin [this message] 2023-11-21 0:51 ` Nicholas Piggin 2023-11-21 9:55 ` Aneesh Kumar K.V 2023-11-22 3:09 ` Masahiro Yamada 2023-11-22 3:09 ` Masahiro Yamada 2023-11-22 12:54 ` Michael Ellerman 2023-11-22 12:54 ` Michael Ellerman 2024-01-30 9:54 ` Jan Stancek 2024-01-30 9:54 ` Jan Stancek 2024-02-05 11:50 ` Michael Ellerman 2024-02-05 11:50 ` Michael Ellerman 2024-02-05 13:21 ` Jan Stancek 2024-02-05 13:21 ` Jan Stancek 2024-02-05 20:50 ` Masahiro Yamada 2024-02-05 20:50 ` Masahiro Yamada 2023-12-07 12:38 ` Michael Ellerman 2023-12-07 12:38 ` Michael Ellerman -- strict thread matches above, loose matches on Subject: below -- 2023-01-19 8:24 Masahiro Yamada 2023-01-19 8:24 ` Masahiro Yamada 2023-01-19 18:44 ` Nathan Chancellor 2023-01-19 18:44 ` Nathan Chancellor
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CX42TU4QHS1Z.A0UUHMDAMZOL@wheely \ --to=npiggin@gmail.com \ --cc=christophe.leroy@csgroup.eu \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=llvm@lists.linux.dev \ --cc=masahiroy@kernel.org \ --cc=mpe@ellerman.id.au \ --cc=nathan@kernel.org \ --cc=ndesaulniers@google.com \ --cc=trix@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.