From: Nathan Lynch <nathanl@linux.ibm.com>
To: Andrew Donnellan <ajd@linux.ibm.com>
Cc: Tyrel Datwyler <tyreld@linux.ibm.com>,
Nick Child <nnac123@linux.ibm.com>,
Scott Cheloha <cheloha@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
Laurent Dufour <ldufour@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 7/8] powerpc/rtas: warn on unsafe argument to rtas_call_unlocked()
Date: Thu, 23 Mar 2023 07:17:05 -0500 [thread overview]
Message-ID: <87mt437jcu.fsf@linux.ibm.com> (raw)
In-Reply-To: <e0f8c82707dce0300fc5a2bc5f0a3ab90a83cee0.camel@linux.ibm.com>
Andrew Donnellan <ajd@linux.ibm.com> writes:
> On Mon, 2023-03-06 at 15:33 -0600, Nathan Lynch via B4 Relay wrote:
>> From: Nathan Lynch <nathanl@linux.ibm.com>
>>
>> Any caller of rtas_call_unlocked() must provide an rtas_args
>> parameter
>> block distinct from the core rtas_args buffer used by the rtas_call()
>> path. It's an unlikely error to make, but the potential consequences
>> are grim, and it's trivial to check.
>>
>> Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
>
> call_rtas_display_status() seems to do exactly this, or am I missing
> something?
No you're right, the warning would be spurious in that case. May need to
drop this one, or refactor rtas_call():
4456f4524604be2558e5f6a8e0f7cc9ed17c783e
Author: Michael Ellerman <mpe@ellerman.id.au>
AuthorDate: Tue Nov 24 22:26:11 2015 +1100
powerpc/rtas: Use rtas_call_unlocked() in call_rtas_display_status()
Although call_rtas_display_status() does actually want to use the
regular RTAS locking, it doesn't want the extra logic that is in
rtas_call(), so currently it open codes the logic.
Instead we can use rtas_call_unlocked(), after taking the RTAS lock.
aside: does anyone know if the display_status() code is worth keeping?
It looks like it is used to drive the 16-character wide physical LCD I
remember seeing on P4-era and older machines. Is it a vestige of
non-LPAR pseries that should be dropped, or is it perhaps useful for
chrp or cell?
next prev parent reply other threads:[~2023-03-23 12:18 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 21:33 [PATCH 0/8] RTAS changes for 6.4 Nathan Lynch via B4 Relay
2023-03-06 21:33 ` Nathan Lynch
2023-03-06 21:33 ` [PATCH 1/8] powerpc/rtas: ensure 8-byte alignment for struct rtas_args Nathan Lynch
2023-03-06 21:33 ` Nathan Lynch via B4 Relay
2023-03-23 4:00 ` Andrew Donnellan
2023-03-06 21:33 ` [PATCH 2/8] powerpc/rtas: use memmove for potentially overlapping buffer copy Nathan Lynch
2023-03-06 21:33 ` Nathan Lynch via B4 Relay
2023-03-23 4:09 ` Andrew Donnellan
2023-03-06 21:33 ` [PATCH 3/8] powerpc/rtas: rtas_call_unlocked() kerneldoc Nathan Lynch via B4 Relay
2023-03-06 21:33 ` Nathan Lynch
2023-03-23 4:15 ` Andrew Donnellan
2023-03-06 21:33 ` [PATCH 4/8] powerpc/rtas: fix miswording in rtas_function kerneldoc Nathan Lynch via B4 Relay
2023-03-06 21:33 ` Nathan Lynch
2023-03-23 0:17 ` Andrew Donnellan
2023-03-06 21:33 ` [PATCH 5/8] powerpc/rtas: rename va_rtas_call_unlocked() to va_rtas_call() Nathan Lynch
2023-03-06 21:33 ` Nathan Lynch via B4 Relay
2023-03-23 4:17 ` Andrew Donnellan
2023-03-23 16:11 ` Nathan Lynch
2023-03-29 12:24 ` Michael Ellerman
2023-03-06 21:33 ` [PATCH 6/8] powerpc/rtas: lockdep annotations Nathan Lynch
2023-03-06 21:33 ` Nathan Lynch via B4 Relay
2023-03-23 6:01 ` Andrew Donnellan
2023-03-06 21:33 ` [PATCH 7/8] powerpc/rtas: warn on unsafe argument to rtas_call_unlocked() Nathan Lynch via B4 Relay
2023-03-06 21:33 ` Nathan Lynch
2023-03-23 4:25 ` Andrew Donnellan
2023-03-23 12:17 ` Nathan Lynch [this message]
2023-03-24 0:56 ` Nathan Lynch
2023-03-29 12:20 ` Michael Ellerman
2023-03-29 16:23 ` Nathan Lynch
2023-03-06 21:33 ` [PATCH 8/8] powerpc/rtas: consume retry statuses in sys_rtas() Nathan Lynch via B4 Relay
2023-03-06 21:33 ` Nathan Lynch
2023-03-23 6:26 ` Andrew Donnellan
2023-03-23 19:39 ` Nathan Lynch
2023-03-23 9:44 ` Michael Ellerman
2023-03-23 13:40 ` Nathan Lynch
2024-01-25 15:55 ` Christophe Leroy
2024-01-25 16:33 ` Nathan Lynch
2024-01-25 16:46 ` Christophe Leroy
2024-01-25 17:23 ` Nathan Lynch
2023-04-06 1:09 ` (subset) [PATCH 0/8] RTAS changes for 6.4 Michael Ellerman
2023-04-26 12:12 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt437jcu.fsf@linux.ibm.com \
--to=nathanl@linux.ibm.com \
--cc=ajd@linux.ibm.com \
--cc=cheloha@linux.ibm.com \
--cc=ldufour@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=nnac123@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.