From: Andrew Donnellan <ajd@linux.ibm.com>
To: nathanl@linux.ibm.com, Michael Ellerman <mpe@ellerman.id.au>,
Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Tyrel Datwyler <tyreld@linux.ibm.com>,
Scott Cheloha <cheloha@linux.ibm.com>,
Laurent Dufour <ldufour@linux.ibm.com>,
linuxppc-dev@lists.ozlabs.org, Nick Child <nnac123@linux.ibm.com>
Subject: Re: [PATCH 4/8] powerpc/rtas: fix miswording in rtas_function kerneldoc
Date: Thu, 23 Mar 2023 11:17:46 +1100 [thread overview]
Message-ID: <c2dbe0a17af1c2816ac038715ec76ff96be2b633.camel@linux.ibm.com> (raw)
In-Reply-To: <20230220-rtas-queue-for-6-4-v1-4-010e4416f13f@linux.ibm.com>
On Mon, 2023-03-06 at 15:33 -0600, Nathan Lynch via B4 Relay wrote:
> From: Nathan Lynch <nathanl@linux.ibm.com>
>
> The 'filter' member is a pointer, not a bool; fix the wording
> accordingly.
>
> Signed-off-by: Nathan Lynch <nathanl@linux.ibm.com>
Reviewed-by: Andrew Donnellan <ajd@linux.ibm.com>
> ---
> arch/powerpc/kernel/rtas.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/powerpc/kernel/rtas.c b/arch/powerpc/kernel/rtas.c
> index c73b01d722f6..c29c38b1a55a 100644
> --- a/arch/powerpc/kernel/rtas.c
> +++ b/arch/powerpc/kernel/rtas.c
> @@ -68,7 +68,7 @@ struct rtas_filter {
> * functions are believed to have no
> users on
> * ppc64le, and we want to keep it that
> way. It does
> * not make sense for this to be set when
> @filter
> - * is false.
> + * is NULL.
> */
> struct rtas_function {
> s32 token;
>
--
Andrew Donnellan OzLabs, ADL Canberra
ajd@linux.ibm.com IBM Australia Limited
next prev parent reply other threads:[~2023-03-23 0:18 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 21:33 [PATCH 0/8] RTAS changes for 6.4 Nathan Lynch via B4 Relay
2023-03-06 21:33 ` Nathan Lynch
2023-03-06 21:33 ` [PATCH 1/8] powerpc/rtas: ensure 8-byte alignment for struct rtas_args Nathan Lynch
2023-03-06 21:33 ` Nathan Lynch via B4 Relay
2023-03-23 4:00 ` Andrew Donnellan
2023-03-06 21:33 ` [PATCH 2/8] powerpc/rtas: use memmove for potentially overlapping buffer copy Nathan Lynch
2023-03-06 21:33 ` Nathan Lynch via B4 Relay
2023-03-23 4:09 ` Andrew Donnellan
2023-03-06 21:33 ` [PATCH 3/8] powerpc/rtas: rtas_call_unlocked() kerneldoc Nathan Lynch via B4 Relay
2023-03-06 21:33 ` Nathan Lynch
2023-03-23 4:15 ` Andrew Donnellan
2023-03-06 21:33 ` [PATCH 4/8] powerpc/rtas: fix miswording in rtas_function kerneldoc Nathan Lynch via B4 Relay
2023-03-06 21:33 ` Nathan Lynch
2023-03-23 0:17 ` Andrew Donnellan [this message]
2023-03-06 21:33 ` [PATCH 5/8] powerpc/rtas: rename va_rtas_call_unlocked() to va_rtas_call() Nathan Lynch
2023-03-06 21:33 ` Nathan Lynch via B4 Relay
2023-03-23 4:17 ` Andrew Donnellan
2023-03-23 16:11 ` Nathan Lynch
2023-03-29 12:24 ` Michael Ellerman
2023-03-06 21:33 ` [PATCH 6/8] powerpc/rtas: lockdep annotations Nathan Lynch
2023-03-06 21:33 ` Nathan Lynch via B4 Relay
2023-03-23 6:01 ` Andrew Donnellan
2023-03-06 21:33 ` [PATCH 7/8] powerpc/rtas: warn on unsafe argument to rtas_call_unlocked() Nathan Lynch via B4 Relay
2023-03-06 21:33 ` Nathan Lynch
2023-03-23 4:25 ` Andrew Donnellan
2023-03-23 12:17 ` Nathan Lynch
2023-03-24 0:56 ` Nathan Lynch
2023-03-29 12:20 ` Michael Ellerman
2023-03-29 16:23 ` Nathan Lynch
2023-03-06 21:33 ` [PATCH 8/8] powerpc/rtas: consume retry statuses in sys_rtas() Nathan Lynch via B4 Relay
2023-03-06 21:33 ` Nathan Lynch
2023-03-23 6:26 ` Andrew Donnellan
2023-03-23 19:39 ` Nathan Lynch
2023-03-23 9:44 ` Michael Ellerman
2023-03-23 13:40 ` Nathan Lynch
2024-01-25 15:55 ` Christophe Leroy
2024-01-25 16:33 ` Nathan Lynch
2024-01-25 16:46 ` Christophe Leroy
2024-01-25 17:23 ` Nathan Lynch
2023-04-06 1:09 ` (subset) [PATCH 0/8] RTAS changes for 6.4 Michael Ellerman
2023-04-26 12:12 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2dbe0a17af1c2816ac038715ec76ff96be2b633.camel@linux.ibm.com \
--to=ajd@linux.ibm.com \
--cc=cheloha@linux.ibm.com \
--cc=christophe.leroy@csgroup.eu \
--cc=ldufour@linux.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=nathanl@linux.ibm.com \
--cc=nnac123@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=tyreld@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.