All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julian Calaby <julian.calaby@gmail.com>
To: Rahul Rameshbabu <sergeantsagara@protonmail.com>
Cc: "Kalle Valo" <kvalo@kernel.org>,
	"Larry Finger" <Larry.Finger@lwfinger.net>,
	"Michael Büsch" <m@bues.ch>,
	linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH wireless v2 1/4] wifi: b43: Stop/wake correct queue in DMA Tx path when QoS is disabled
Date: Mon, 1 Jan 2024 19:01:10 +1100	[thread overview]
Message-ID: <CAGRGNgWjmae+OOp1YpejtKuPwvz0RKDKF+M+UAGx91OX+bJrcA@mail.gmail.com> (raw)
In-Reply-To: <20231231050300.122806-2-sergeantsagara@protonmail.com>

Hi Rahul,

On Sun, Dec 31, 2023 at 4:03 PM Rahul Rameshbabu
<sergeantsagara@protonmail.com> wrote:
>
> When QoS is disabled, the queue priority value will not map to the correct
> ieee80211 queue since there is only one queue. Stop/wake queue 0 when QoS
> is disabled to prevent trying to stop/wake a non-existent queue and failing
> to stop/wake the actual queue instantiated.
>
> [snip]
>
> Fixes: e6f5b934fba8 ("b43: Add QOS support")
> Signed-off-by: Rahul Rameshbabu <sergeantsagara@protonmail.com>

LGTM

Reviewed-by: Julian Calaby <julian.calaby@gmail.com>

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

WARNING: multiple messages have this Message-ID (diff)
From: Julian Calaby <julian.calaby@gmail.com>
To: Rahul Rameshbabu <sergeantsagara@protonmail.com>
Cc: "Kalle Valo" <kvalo@kernel.org>,
	"Larry Finger" <Larry.Finger@lwfinger.net>,
	"Michael Büsch" <m@bues.ch>,
	linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH wireless v2 1/4] wifi: b43: Stop/wake correct queue in DMA Tx path when QoS is disabled
Date: Mon, 1 Jan 2024 19:01:10 +1100	[thread overview]
Message-ID: <CAGRGNgWjmae+OOp1YpejtKuPwvz0RKDKF+M+UAGx91OX+bJrcA@mail.gmail.com> (raw)
In-Reply-To: <20231231050300.122806-2-sergeantsagara@protonmail.com>

Hi Rahul,

On Sun, Dec 31, 2023 at 4:03 PM Rahul Rameshbabu
<sergeantsagara@protonmail.com> wrote:
>
> When QoS is disabled, the queue priority value will not map to the correct
> ieee80211 queue since there is only one queue. Stop/wake queue 0 when QoS
> is disabled to prevent trying to stop/wake a non-existent queue and failing
> to stop/wake the actual queue instantiated.
>
> [snip]
>
> Fixes: e6f5b934fba8 ("b43: Add QOS support")
> Signed-off-by: Rahul Rameshbabu <sergeantsagara@protonmail.com>

LGTM

Reviewed-by: Julian Calaby <julian.calaby@gmail.com>

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/

_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev

  reply	other threads:[~2024-01-01  8:01 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-31  5:03 [PATCH wireless v2 0/4] wifi: b43: Various QoS-related fixes Rahul Rameshbabu
2023-12-31  5:03 ` Rahul Rameshbabu
2023-12-31  5:03 ` [PATCH wireless v2 1/4] wifi: b43: Stop/wake correct queue in DMA Tx path when QoS is disabled Rahul Rameshbabu
2023-12-31  5:03   ` Rahul Rameshbabu
2024-01-01  8:01   ` Julian Calaby [this message]
2024-01-01  8:01     ` Julian Calaby
2024-01-10 14:56   ` Kalle Valo
2024-01-10 14:56     ` Kalle Valo
2023-12-31  5:03 ` [PATCH wireless v2 2/4] wifi: b43: Stop/wake correct queue in PIO " Rahul Rameshbabu
2023-12-31  5:03   ` Rahul Rameshbabu
2024-01-01  8:02   ` Julian Calaby
2024-01-01  8:02     ` Julian Calaby
2023-12-31  5:03 ` [PATCH wireless v2 3/4] wifi: b43: Stop correct queue in DMA worker " Rahul Rameshbabu
2023-12-31  5:03   ` Rahul Rameshbabu
2024-01-01  8:03   ` Julian Calaby
2024-01-01  8:03     ` Julian Calaby
2023-12-31  5:03 ` [PATCH wireless v2 4/4] wifi: b43: Disable QoS for bcm4331 Rahul Rameshbabu
2023-12-31  5:03   ` Rahul Rameshbabu
2024-01-01  8:05   ` Julian Calaby
2024-01-01  8:05     ` Julian Calaby
2023-12-31  9:26 ` [PATCH wireless v2 0/4] wifi: b43: Various QoS-related fixes Michael Büsch
2023-12-31  9:26   ` Michael Büsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAGRGNgWjmae+OOp1YpejtKuPwvz0RKDKF+M+UAGx91OX+bJrcA@mail.gmail.com \
    --to=julian.calaby@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=b43-dev@lists.infradead.org \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=m@bues.ch \
    --cc=sergeantsagara@protonmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.