Re: [PATCH wireless v2 4/4] wifi: b43: Disable QoS for bcm4331

From: Julian Calaby <julian.calaby@gmail.com>
To: Rahul Rameshbabu <sergeantsagara@protonmail.com>
Cc: "Kalle Valo" <kvalo@kernel.org>,
	"Larry Finger" <Larry.Finger@lwfinger.net>,
	"Michael Büsch" <m@bues.ch>,
	linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH wireless v2 4/4] wifi: b43: Disable QoS for bcm4331
Date: Mon, 1 Jan 2024 19:05:01 +1100	[thread overview]
Message-ID: <CAGRGNgXYBM16UNcHmOVMJKa+C5R9-Hy7vamEBpp=cF_heQVX6Q@mail.gmail.com> (raw)
In-Reply-To: <20231231050300.122806-5-sergeantsagara@protonmail.com>

Hi Rahul,

On Sun, Dec 31, 2023 at 4:04 PM Rahul Rameshbabu
<sergeantsagara@protonmail.com> wrote:
>
> bcm4331 seems to not function correctly with QoS support. This may be due
> to issues with currently available firmware or potentially a device
> specific issue.
>
> When queues that are not of the default "best effort" priority are
> selected, traffic appears to not transmit out of the hardware while no
> errors are returned. This behavior is present among all the other priority
> queues: video, voice, and background. While this can be worked around by
> setting a kernel parameter, the default behavior is problematic for most
> users and may be difficult to debug. This patch offers a working out-of-box
> experience for bcm4331 users.
>
> [snip]
>
> Fixes: e6f5b934fba8 ("b43: Add QOS support")
> Signed-off-by: Rahul Rameshbabu <sergeantsagara@protonmail.com>

LGTM

Reviewed-by: Julian Calaby <julian.calaby@gmail.com>

Thanks,

-- 
Julian Calaby

Email: julian.calaby@gmail.com
Profile: http://www.google.com/profiles/julian.calaby/