From: Jason Gunthorpe <jgg@ziepe.ca>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Theodore Ts'o <tytso@mit.edu>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Linus Torvalds <torvalds@linuxfoundation.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
tools@linux.kernel.org, users@linux.kernel.org
Subject: Re: b4-0.9.0 available
Date: Fri, 24 Jun 2022 13:06:28 -0300 [thread overview]
Message-ID: <20220624160628.GB23621@ziepe.ca> (raw)
In-Reply-To: <20220624155213.4wfbnttowgom2sjz@meerkat.local>
On Fri, Jun 24, 2022 at 11:52:13AM -0400, Konstantin Ryabitsev wrote:
> On Fri, Jun 24, 2022 at 11:29:44AM -0400, Theodore Ts'o wrote:
> > It would be great if we had some kind of tooling where when someone
> > sends a new version of the patch series, the tooling opened an editor
> > and allowed the submitted to enter a quick changelog of what changed
> > between the v25 and v26 version of the patch, with an option to also
> > edit the body of the cover letter. And then then when the patch is
> > sent via e-mail, all of this would be appended to the cummulative
> > version of the cover letter.
>
> This feature is in-flight for "b4 submit". I wrote about it here:
> https://lore.kernel.org/git/20211217183942.npvkb3ajnx6p5cbp@meerkat.local/
>
> Here's the relevant part, slightly updated with the latest info:
>
> 1. b4 submit --new: this will create a new tracking branch and define
> some metadata to go with it, such as a cover letter template. The cover
> letter can be edited using `b4 submit --edit-cover` at any time.
It would be nice if this could store the cover letter in an empty git
commit at the top of the branch.
At least here we always require cover letters to be reviewed (eg in
gerrit/gitlab/whatever) along with patches and having them stored as
notes or in the branch description that is not git pushable is not so
useful.
> 2. b4 submit --send: will generate a patch series from any commits created
> from the topical branch fork point and use the cover letter from the
> previous step. It will be able to send the patches using the traditional
> SMTP way, OR it will allow using a web-based submission service that will
> eventually be set up at kernel.org:
In my tooling I build a git commit that contains the raw final emails
sent, the message-id's that were used, a link to lore, and the git
commit range that bounds what was sent, then log this commit as an
dated archival branch so I can have a good idea of where everything is
and recover back to the exact git commits sent if I need to. Sort of
an enhanced 'reflog'.
I find it is really important be able to go back to the lore link of
the historical version(s) easially.
> 4. b4 submit --sync: will retrieve any received code review trailers
> (reviewed-by, acked-by, etc) and amend the corresponding commits in the
> topical branch, assuming we can match patch-id's (I've not tackled this
> yet, so I may be unduly optimistic here).
Yay, I hope this is generally usable :)
> 5. b4 submit --reroll: will prepare a v2 (v3, v4) of the series, reusing the
> same change-id trailer and adding a templated "Changes in v2" entry to the
> cover letter (that must be edited before --send works again).
With an automatic lore url to the prior version?
Jason
next prev parent reply other threads:[~2022-06-24 16:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 19:01 b4-0.9.0 available Konstantin Ryabitsev
2022-06-20 8:40 ` Geert Uytterhoeven
2022-06-21 23:38 ` Linus Walleij
2022-06-22 5:49 ` Vinod Koul
2022-06-21 15:20 ` Geert Uytterhoeven
2022-06-21 15:29 ` Konstantin Ryabitsev
2022-06-21 15:41 ` Geert Uytterhoeven
2022-06-21 15:55 ` Linus Torvalds
2022-06-21 16:03 ` Jason A. Donenfeld
2022-06-21 16:59 ` Konstantin Ryabitsev
2022-06-21 17:49 ` Jason A. Donenfeld
2022-06-21 18:29 ` Konstantin Ryabitsev
2022-06-21 18:45 ` Jason A. Donenfeld
2022-06-21 19:27 ` Konstantin Ryabitsev
2022-06-21 19:42 ` Jason A. Donenfeld
2022-06-21 19:43 ` Geert Uytterhoeven
2022-06-21 19:50 ` Jason A. Donenfeld
2022-06-21 20:06 ` Konstantin Ryabitsev
2022-06-21 20:29 ` Jason A. Donenfeld
2022-06-21 21:25 ` Bjorn Andersson
2022-06-23 23:33 ` Theodore Ts'o
2022-06-24 13:51 ` Jason Gunthorpe
2022-06-24 15:29 ` Theodore Ts'o
2022-06-24 15:34 ` Mark Brown
2022-06-24 16:05 ` Theodore Ts'o
2022-06-24 15:52 ` Konstantin Ryabitsev
2022-06-24 16:05 ` James Bottomley
2022-06-24 16:16 ` Konstantin Ryabitsev
2022-06-24 16:29 ` James Bottomley
2022-06-24 16:06 ` Jason Gunthorpe [this message]
2022-06-24 16:16 ` Mark Brown
2022-06-24 17:51 ` Chuck Lever
2022-06-24 8:34 ` Nicolas Ferre
2022-06-21 15:53 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220624160628.GB23621@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=Jason@zx2c4.com \
--cc=bjorn.andersson@linaro.org \
--cc=geert@linux-m68k.org \
--cc=konstantin@linuxfoundation.org \
--cc=tools@linux.kernel.org \
--cc=torvalds@linuxfoundation.org \
--cc=tytso@mit.edu \
--cc=users@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.