From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Linus Torvalds <torvalds@linuxfoundation.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
tools@linux.kernel.org, users@linux.kernel.org
Subject: Re: b4-0.9.0 available
Date: Tue, 21 Jun 2022 19:49:18 +0200 [thread overview]
Message-ID: <YrIEnmt5vDMcbOiG@zx2c4.com> (raw)
In-Reply-To: <20220621165953.z25hwos7gom6bp6s@meerkat.local>
Hi Konstantin,
On Tue, Jun 21, 2022 at 12:59:53PM -0400, Konstantin Ryabitsev wrote:
> On Tue, Jun 21, 2022 at 06:03:30PM +0200, Jason A. Donenfeld wrote:
> > Very much so. But if you look at various commits from the last 2 or 3
> > years, this is now disregarded pretty regularly. It'd be nice to see
> > the tooling preventing this kind of error rather than encouraging it.
>
> The default for b4 since version 0.6 (2020) has been not to preserve the
> existing trailer order and append any new ones at the bottom.
Huh, interesting. Is this a stable-distro or Debian thing, I wonder,
where maintainers are using an old b4? Or perhaps more likely, b4 still
has that option, and so people are using that option, even if it's not
the default?
IMO, you should remove both the "sort S-o-b into meaninglessness" and
the "add a useless Link: trailer that wastes my time when I middle click
it" options, so that it's harder to make these mistakes.
Looking at the man page, it seems like you make these mistakes very easy
and give people some example configs even:
# When processing thread trailers, sort them in this order.
# Can use shell-globbing and must end with ,*
# Some sorting orders:
#trailer-order=link*,fixes*,cc*,reported*,suggested*,original*,co-*,tested*,reviewed*,acked*,signed-off*,*
#trailer-order = fixes*,reported*,suggested*,original*,co-*,signed-off*,tested*,reviewed*,acked*,cc*,link*,*
trailer-order = _preserve_
Just remove the functionality?
Jason
next prev parent reply other threads:[~2022-06-21 17:49 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 19:01 b4-0.9.0 available Konstantin Ryabitsev
2022-06-20 8:40 ` Geert Uytterhoeven
2022-06-21 23:38 ` Linus Walleij
2022-06-22 5:49 ` Vinod Koul
2022-06-21 15:20 ` Geert Uytterhoeven
2022-06-21 15:29 ` Konstantin Ryabitsev
2022-06-21 15:41 ` Geert Uytterhoeven
2022-06-21 15:55 ` Linus Torvalds
2022-06-21 16:03 ` Jason A. Donenfeld
2022-06-21 16:59 ` Konstantin Ryabitsev
2022-06-21 17:49 ` Jason A. Donenfeld [this message]
2022-06-21 18:29 ` Konstantin Ryabitsev
2022-06-21 18:45 ` Jason A. Donenfeld
2022-06-21 19:27 ` Konstantin Ryabitsev
2022-06-21 19:42 ` Jason A. Donenfeld
2022-06-21 19:43 ` Geert Uytterhoeven
2022-06-21 19:50 ` Jason A. Donenfeld
2022-06-21 20:06 ` Konstantin Ryabitsev
2022-06-21 20:29 ` Jason A. Donenfeld
2022-06-21 21:25 ` Bjorn Andersson
2022-06-23 23:33 ` Theodore Ts'o
2022-06-24 13:51 ` Jason Gunthorpe
2022-06-24 15:29 ` Theodore Ts'o
2022-06-24 15:34 ` Mark Brown
2022-06-24 16:05 ` Theodore Ts'o
2022-06-24 15:52 ` Konstantin Ryabitsev
2022-06-24 16:05 ` James Bottomley
2022-06-24 16:16 ` Konstantin Ryabitsev
2022-06-24 16:29 ` James Bottomley
2022-06-24 16:06 ` Jason Gunthorpe
2022-06-24 16:16 ` Mark Brown
2022-06-24 17:51 ` Chuck Lever
2022-06-24 8:34 ` Nicolas Ferre
2022-06-21 15:53 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrIEnmt5vDMcbOiG@zx2c4.com \
--to=jason@zx2c4.com \
--cc=geert@linux-m68k.org \
--cc=konstantin@linuxfoundation.org \
--cc=tools@linux.kernel.org \
--cc=torvalds@linuxfoundation.org \
--cc=users@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.