From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>,
"Jason A. Donenfeld" <Jason@zx2c4.com>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Linus Torvalds <torvalds@linuxfoundation.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
<tools@linux.kernel.org>, <users@linux.kernel.org>
Subject: Re: b4-0.9.0 available
Date: Fri, 24 Jun 2022 10:34:09 +0200 [thread overview]
Message-ID: <3d00ccd4-509b-f350-2612-ea0b0c8d2743@microchip.com> (raw)
In-Reply-To: <YrI3W46GUS/Dap5J@ripper>
On 21/06/2022 at 23:25, Bjorn Andersson wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On Tue 21 Jun 11:45 PDT 2022, Jason A. Donenfeld wrote:
>
>> Hi Konstantin,
>>
>> On Tue, Jun 21, 2022 at 02:29:53PM -0400, Konstantin Ryabitsev wrote:
>>> If there is someone who is willing to compile a definitive list of "Linux
>>> Kernel commit do's and dont's", then I'll happily stick to that.
>>
>> I dunno about a "definitive list". But it seems like a lot of
>> conventions get solidified by way of tools that are ironed out over
>> time. For example, every time a code style discussion comes up, Joe
>> Perches arrives on the scene to make sure checkpatch.pl is current. And
>> now the clang-format file is starting to also accumulate collective
>> preferences. It seems like b4 is pretty widely used and will eventually
>> serve a similar purpose if it doesn't already do so.
>>
>> Anyway, in lieu of a complete and thorough list of all of the things, it
>> seems like in the last week or so we at least have two things that can
>> be be reflected in the tooling:
>>
>> - Don't add `Link:` if the URL hasn't been hand selected as being
>> particularly relevant; the lkml patch email alone doesn't cut it. This
>> suggests that automatically adding `Link:` is invariably wrong, since
>> automatic != "hand selected", so maybe there's no point in
>> `-l,--add-link`, and you can just remove that option.
Please no...
> FWIW I find it very helpful to have the lore-Link in patches, as that
> allow me to quickly find and share a pointer to already landed
> patch/patchset - in particular when the recipient doesn't have
> linux-next synced and checked out locally.
>
> And I don't mind there being multiple Link: tags to different resources,
> as the various automation use cases I've run into have been easily
> solved by just filtering the tags by domain...
+1
"Link: " addition has been very useful also for me several times when
coming back to applied patches, even simple one carrying no real
information at first sight.
Even the lack of discussion associated to a patch is sometimes a good
indicator that the merged patch was not questioned or exercised enough,
and we can easily realize this by following the "Link:" tag.
Not only it links to email thread at the time of patch merging, but as
time passes, it could even link to a discussion that happened *after*
that the patch had been merged. This discussion can address regressions,
remarks or request for follow-up. As developers, *easily* following this
"Link:" brings value in my opinion.
[..]
Best regards,
Nicolas
--
Nicolas Ferre
next prev parent reply other threads:[~2022-06-24 8:34 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 19:01 b4-0.9.0 available Konstantin Ryabitsev
2022-06-20 8:40 ` Geert Uytterhoeven
2022-06-21 23:38 ` Linus Walleij
2022-06-22 5:49 ` Vinod Koul
2022-06-21 15:20 ` Geert Uytterhoeven
2022-06-21 15:29 ` Konstantin Ryabitsev
2022-06-21 15:41 ` Geert Uytterhoeven
2022-06-21 15:55 ` Linus Torvalds
2022-06-21 16:03 ` Jason A. Donenfeld
2022-06-21 16:59 ` Konstantin Ryabitsev
2022-06-21 17:49 ` Jason A. Donenfeld
2022-06-21 18:29 ` Konstantin Ryabitsev
2022-06-21 18:45 ` Jason A. Donenfeld
2022-06-21 19:27 ` Konstantin Ryabitsev
2022-06-21 19:42 ` Jason A. Donenfeld
2022-06-21 19:43 ` Geert Uytterhoeven
2022-06-21 19:50 ` Jason A. Donenfeld
2022-06-21 20:06 ` Konstantin Ryabitsev
2022-06-21 20:29 ` Jason A. Donenfeld
2022-06-21 21:25 ` Bjorn Andersson
2022-06-23 23:33 ` Theodore Ts'o
2022-06-24 13:51 ` Jason Gunthorpe
2022-06-24 15:29 ` Theodore Ts'o
2022-06-24 15:34 ` Mark Brown
2022-06-24 16:05 ` Theodore Ts'o
2022-06-24 15:52 ` Konstantin Ryabitsev
2022-06-24 16:05 ` James Bottomley
2022-06-24 16:16 ` Konstantin Ryabitsev
2022-06-24 16:29 ` James Bottomley
2022-06-24 16:06 ` Jason Gunthorpe
2022-06-24 16:16 ` Mark Brown
2022-06-24 17:51 ` Chuck Lever
2022-06-24 8:34 ` Nicolas Ferre [this message]
2022-06-21 15:53 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d00ccd4-509b-f350-2612-ea0b0c8d2743@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=Jason@zx2c4.com \
--cc=bjorn.andersson@linaro.org \
--cc=geert@linux-m68k.org \
--cc=konstantin@linuxfoundation.org \
--cc=tools@linux.kernel.org \
--cc=torvalds@linuxfoundation.org \
--cc=users@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.