From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Linus Torvalds <torvalds@linuxfoundation.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
tools@linux.kernel.org, users@linux.kernel.org
Subject: Re: b4-0.9.0 available
Date: Tue, 21 Jun 2022 21:42:22 +0200 [thread overview]
Message-ID: <YrIfHvaxCUVfQ7D8@zx2c4.com> (raw)
In-Reply-To: <20220621192724.ls6q6fyr6ehtsyah@meerkat.local>
Hi Konstantin,
On Tue, Jun 21, 2022 at 03:27:24PM -0400, Konstantin Ryabitsev wrote:
> I think the discussion veered towards "don't call it Link:", not "don't link
> to it at all". Without "BugLink" in the running, the next winning option was
> "Archived-at:" and I am considering towards making -l add that trailer
> instead, with the custom msgid.link domain, to further distinguish it from
> "hand selected" lore links:
>
> Archived-at: https://msgid.link/20220617190153.tvi5lkzlvemeqou5@meerkat.local
>
> I am not currently working on that, though, so I'm happy to go either way,
> including making -l a "does nothing" switch.
Oh. I thought it wound up concluding that none of this was necessary and
instead the tooling could be fixed server-side, so that you could have
patchwork query "hey which mailing list post is patch 0123456789abcdef?"
and it'll tell you that, or vice versa, especially since it's not always
clear which patch version is the most relevant, as sometimes things are
tweaked after the fact, and so some fuzzy sorting is usually required.
In other words, no need to store this inline with commits, and a service
can handle that more flexibly anyway.
> > - Don't reorder `Signed-off-by:`. The simplest thing to do would be to
> > remove the `trailer-order` option all together. But some people do
> > want to sort the trailers (within each S-o-b segment) for aesthetic
> > purposes. So if you don't want to take that away from them, maybe
> > S-o-b needs to be unconditionally special-cased so that it forms a
> > reorder barrier.
>
> This is already the case for all trailers -- we *group* them by trailer name,
> but the *order* in which they are written is preserved. E.g. with the config
> option trailer-order="reported-by,reviewed-by,signed-off-by,*', we go from:
>
> Signed-off-by: Ze Developer <ze@example.dev>
> Reviewed-by: Some Rando <rando@example.dev>
> Reviewed-by: Managing Rando <mgmt@example.dev>
> Signed-off-by: Awesome Maintainer <aw@example.dev>
> Reported-by: Bug Finder <bug@example.dev>
>
>
> to:
>
> Reported-by: Bug Finder <bug@example.dev>
> Reviewed-by: Some Rando <rando@example.dev>
> Reviewed-by: Managing Rando <mgmt@example.dev>
> Signed-off-by: Ze Developer <ze@example.dev>
> Signed-off-by: Awesome Maintainer <aw@example.dev>
>
> Perhaps I should call the setting "trailer-grouping" instead of
> "trailer-order" (it's called that because we did reorder them alphabetically
> at some point in the distant past when the feature was first implemented).
I don't know what that first block is, since the Reported-by comes after
a Signed-off-by line, which means it's already ambiguous and wrong. But
even if we throw away that line, your new snippet is still wrong, since
now it shows Ze Developer having collected those Reviewed-bys, when
Awesome Maintainer is the one who did it.
In other words, if we start with this:
Signed-off-by: Ze Developer <ze@example.dev>
Reviewed-by: Some Rando <rando@example.dev>
Reported-by: Bug Finder <bug@example.dev>
Reviewed-by: Managing Rando <mgmt@example.dev>
Signed-off-by: Awesome Maintainer <aw@example.dev>
A valid reordering is this:
Signed-off-by: Ze Developer <ze@example.dev>
Reviewed-by: Some Rando <rando@example.dev>
Reviewed-by: Managing Rando <mgmt@example.dev>
Reported-by: Bug Finder <bug@example.dev>
Signed-off-by: Awesome Maintainer <aw@example.dev>
But NOT:
Reviewed-by: Some Rando <rando@example.dev>
Reviewed-by: Managing Rando <mgmt@example.dev>
Reported-by: Bug Finder <bug@example.dev>
Signed-off-by: Ze Developer <ze@example.dev>
Signed-off-by: Awesome Maintainer <aw@example.dev>
Since the bad one obscures who collected the tags.
The prevailing idea is that each hop in the custody chain has their
"S-o-b area", which is the zone above their S-o-b and below the previous
S-o-b. Sometimes such areas accumulate text too, such as:
[ Replaced turboencabulator jet fuel with diesel. ]
So if you sort, fine, but don't sort across S-o-b lines. Those form an
ordering barrier.
Jason
next prev parent reply other threads:[~2022-06-21 19:42 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 19:01 b4-0.9.0 available Konstantin Ryabitsev
2022-06-20 8:40 ` Geert Uytterhoeven
2022-06-21 23:38 ` Linus Walleij
2022-06-22 5:49 ` Vinod Koul
2022-06-21 15:20 ` Geert Uytterhoeven
2022-06-21 15:29 ` Konstantin Ryabitsev
2022-06-21 15:41 ` Geert Uytterhoeven
2022-06-21 15:55 ` Linus Torvalds
2022-06-21 16:03 ` Jason A. Donenfeld
2022-06-21 16:59 ` Konstantin Ryabitsev
2022-06-21 17:49 ` Jason A. Donenfeld
2022-06-21 18:29 ` Konstantin Ryabitsev
2022-06-21 18:45 ` Jason A. Donenfeld
2022-06-21 19:27 ` Konstantin Ryabitsev
2022-06-21 19:42 ` Jason A. Donenfeld [this message]
2022-06-21 19:43 ` Geert Uytterhoeven
2022-06-21 19:50 ` Jason A. Donenfeld
2022-06-21 20:06 ` Konstantin Ryabitsev
2022-06-21 20:29 ` Jason A. Donenfeld
2022-06-21 21:25 ` Bjorn Andersson
2022-06-23 23:33 ` Theodore Ts'o
2022-06-24 13:51 ` Jason Gunthorpe
2022-06-24 15:29 ` Theodore Ts'o
2022-06-24 15:34 ` Mark Brown
2022-06-24 16:05 ` Theodore Ts'o
2022-06-24 15:52 ` Konstantin Ryabitsev
2022-06-24 16:05 ` James Bottomley
2022-06-24 16:16 ` Konstantin Ryabitsev
2022-06-24 16:29 ` James Bottomley
2022-06-24 16:06 ` Jason Gunthorpe
2022-06-24 16:16 ` Mark Brown
2022-06-24 17:51 ` Chuck Lever
2022-06-24 8:34 ` Nicolas Ferre
2022-06-21 15:53 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrIfHvaxCUVfQ7D8@zx2c4.com \
--to=jason@zx2c4.com \
--cc=geert@linux-m68k.org \
--cc=konstantin@linuxfoundation.org \
--cc=tools@linux.kernel.org \
--cc=torvalds@linuxfoundation.org \
--cc=users@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.