From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc: Linus Torvalds <torvalds@linuxfoundation.org>,
Geert Uytterhoeven <geert@linux-m68k.org>,
tools@linux.kernel.org, users@linux.kernel.org
Subject: Re: b4-0.9.0 available
Date: Tue, 21 Jun 2022 20:45:46 +0200 [thread overview]
Message-ID: <YrIR2v7GdC3qIt2E@zx2c4.com> (raw)
In-Reply-To: <20220621182953.p5asczznnz3pn6dl@meerkat.local>
Hi Konstantin,
On Tue, Jun 21, 2022 at 02:29:53PM -0400, Konstantin Ryabitsev wrote:
> If there is someone who is willing to compile a definitive list of "Linux
> Kernel commit do's and dont's", then I'll happily stick to that.
I dunno about a "definitive list". But it seems like a lot of
conventions get solidified by way of tools that are ironed out over
time. For example, every time a code style discussion comes up, Joe
Perches arrives on the scene to make sure checkpatch.pl is current. And
now the clang-format file is starting to also accumulate collective
preferences. It seems like b4 is pretty widely used and will eventually
serve a similar purpose if it doesn't already do so.
Anyway, in lieu of a complete and thorough list of all of the things, it
seems like in the last week or so we at least have two things that can
be be reflected in the tooling:
- Don't add `Link:` if the URL hasn't been hand selected as being
particularly relevant; the lkml patch email alone doesn't cut it. This
suggests that automatically adding `Link:` is invariably wrong, since
automatic != "hand selected", so maybe there's no point in
`-l,--add-link`, and you can just remove that option.
- Don't reorder `Signed-off-by:`. The simplest thing to do would be to
remove the `trailer-order` option all together. But some people do
want to sort the trailers (within each S-o-b segment) for aesthetic
purposes. So if you don't want to take that away from them, maybe
S-o-b needs to be unconditionally special-cased so that it forms a
reorder barrier.
#define sob(name) do { smp_mb(); __sob(name); } while (0)
Jason
next prev parent reply other threads:[~2022-06-21 18:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-17 19:01 b4-0.9.0 available Konstantin Ryabitsev
2022-06-20 8:40 ` Geert Uytterhoeven
2022-06-21 23:38 ` Linus Walleij
2022-06-22 5:49 ` Vinod Koul
2022-06-21 15:20 ` Geert Uytterhoeven
2022-06-21 15:29 ` Konstantin Ryabitsev
2022-06-21 15:41 ` Geert Uytterhoeven
2022-06-21 15:55 ` Linus Torvalds
2022-06-21 16:03 ` Jason A. Donenfeld
2022-06-21 16:59 ` Konstantin Ryabitsev
2022-06-21 17:49 ` Jason A. Donenfeld
2022-06-21 18:29 ` Konstantin Ryabitsev
2022-06-21 18:45 ` Jason A. Donenfeld [this message]
2022-06-21 19:27 ` Konstantin Ryabitsev
2022-06-21 19:42 ` Jason A. Donenfeld
2022-06-21 19:43 ` Geert Uytterhoeven
2022-06-21 19:50 ` Jason A. Donenfeld
2022-06-21 20:06 ` Konstantin Ryabitsev
2022-06-21 20:29 ` Jason A. Donenfeld
2022-06-21 21:25 ` Bjorn Andersson
2022-06-23 23:33 ` Theodore Ts'o
2022-06-24 13:51 ` Jason Gunthorpe
2022-06-24 15:29 ` Theodore Ts'o
2022-06-24 15:34 ` Mark Brown
2022-06-24 16:05 ` Theodore Ts'o
2022-06-24 15:52 ` Konstantin Ryabitsev
2022-06-24 16:05 ` James Bottomley
2022-06-24 16:16 ` Konstantin Ryabitsev
2022-06-24 16:29 ` James Bottomley
2022-06-24 16:06 ` Jason Gunthorpe
2022-06-24 16:16 ` Mark Brown
2022-06-24 17:51 ` Chuck Lever
2022-06-24 8:34 ` Nicolas Ferre
2022-06-21 15:53 ` Jason A. Donenfeld
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YrIR2v7GdC3qIt2E@zx2c4.com \
--to=jason@zx2c4.com \
--cc=geert@linux-m68k.org \
--cc=konstantin@linuxfoundation.org \
--cc=tools@linux.kernel.org \
--cc=torvalds@linuxfoundation.org \
--cc=users@linux.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.